You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/06/02 09:24:35 UTC

[GitHub] [skywalking-banyandb] remGigo opened a new pull request, #127: Fix protobuf file typo

remGigo opened a new pull request, #127:
URL: https://github.com/apache/skywalking-banyandb/pull/127

   Fix protobuf  file typo


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #127: Fix protobuf file typo

Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on code in PR #127:
URL: https://github.com/apache/skywalking-banyandb/pull/127#discussion_r887791729


##########
api/proto/banyandb/property/v1/rpc.proto:
##########
@@ -56,7 +56,7 @@ message GetResponse {
 }
 
 message ListRequest {
-    banyandb.common.v1.Metadata contaner = 1;
+    banyandb.common.v1.Metadata container = 1;

Review Comment:
   > I see, and I wonder is "make generate" at root directory all i need to do ? By the way, if i run "make generate", there are over a hundred files that have their format changed, most of which are removed with some whitespace lines in the "import" module. Is that ok?
   
   A hundred files? Not possible, it will only make necessary changes. I guess in your case, only `rpc.pb.go` will change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] remGigo commented on a diff in pull request #127: Fix protobuf file typo

Posted by GitBox <gi...@apache.org>.
remGigo commented on code in PR #127:
URL: https://github.com/apache/skywalking-banyandb/pull/127#discussion_r887956037


##########
api/proto/banyandb/property/v1/rpc.proto:
##########
@@ -56,7 +56,7 @@ message GetResponse {
 }
 
 message ListRequest {
-    banyandb.common.v1.Metadata contaner = 1;
+    banyandb.common.v1.Metadata container = 1;

Review Comment:
   
   
   
   > The formatted codes (in 3 blocks) are generated by `goimports`. Have you installed the latest `goimports` globally and make sure it can be found within the `PATH`?
   > 
   > Pls refer to the official document, https://pkg.go.dev/golang.org/x/tools/cmd/goimports
   
   I ignored goimports error information. My fault, thanks!!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #127: Fix protobuf file typo

Posted by GitBox <gi...@apache.org>.
hanahmily commented on code in PR #127:
URL: https://github.com/apache/skywalking-banyandb/pull/127#discussion_r887863741


##########
api/proto/banyandb/property/v1/rpc.proto:
##########
@@ -56,7 +56,7 @@ message GetResponse {
 }
 
 message ListRequest {
-    banyandb.common.v1.Metadata contaner = 1;
+    banyandb.common.v1.Metadata container = 1;

Review Comment:
   To issue `make format` after generating codes. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] hanahmily commented on pull request #127: Fix protobuf file typo

Posted by GitBox <gi...@apache.org>.
hanahmily commented on PR #127:
URL: https://github.com/apache/skywalking-banyandb/pull/127#issuecomment-1144781415

   I fixed this in https://github.com/apache/skywalking-banyandb/pull/128


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #127: Fix protobuf file typo

Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on code in PR #127:
URL: https://github.com/apache/skywalking-banyandb/pull/127#discussion_r887757257


##########
api/proto/banyandb/property/v1/rpc.proto:
##########
@@ -56,7 +56,7 @@ message GetResponse {
 }
 
 message ListRequest {
-    banyandb.common.v1.Metadata contaner = 1;
+    banyandb.common.v1.Metadata container = 1;

Review Comment:
   When you change this file, the references in the source codes also have to be changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #127: Fix protobuf file typo

Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on PR #127:
URL: https://github.com/apache/skywalking-banyandb/pull/127#issuecomment-1144648346

   You have to generate `*.proto.go` files locally and commit them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] wu-sheng commented on pull request #127: Fix protobuf file typo

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #127:
URL: https://github.com/apache/skywalking-banyandb/pull/127#issuecomment-1144658576

   FYI @hanahmily 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #127: Fix protobuf file typo

Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on code in PR #127:
URL: https://github.com/apache/skywalking-banyandb/pull/127#discussion_r887840855


##########
api/proto/banyandb/property/v1/rpc.proto:
##########
@@ -56,7 +56,7 @@ message GetResponse {
 }
 
 message ListRequest {
-    banyandb.common.v1.Metadata contaner = 1;
+    banyandb.common.v1.Metadata container = 1;

Review Comment:
   The formatted codes (in 3 blocks) are generated by `goimports`. Have you installed the latest `goimports` globally and make sure it can be found within the `PATH`?
   
   Pls refer to the official document,
   https://pkg.go.dev/golang.org/x/tools/cmd/goimports



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] hanahmily commented on pull request #127: Fix protobuf file typo

Posted by GitBox <gi...@apache.org>.
hanahmily commented on PR #127:
URL: https://github.com/apache/skywalking-banyandb/pull/127#issuecomment-1144757317

   Please run `make generate` and `make format` to pass the check test. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #127: Fix protobuf file typo

Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on code in PR #127:
URL: https://github.com/apache/skywalking-banyandb/pull/127#discussion_r887840855


##########
api/proto/banyandb/property/v1/rpc.proto:
##########
@@ -56,7 +56,7 @@ message GetResponse {
 }
 
 message ListRequest {
-    banyandb.common.v1.Metadata contaner = 1;
+    banyandb.common.v1.Metadata container = 1;

Review Comment:
   The formatted codes (in 3 blocks) are generated by `goimports`. Have you installed the latest `goimports` globally?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] remGigo commented on a diff in pull request #127: Fix protobuf file typo

Posted by GitBox <gi...@apache.org>.
remGigo commented on code in PR #127:
URL: https://github.com/apache/skywalking-banyandb/pull/127#discussion_r887789399


##########
api/proto/banyandb/property/v1/rpc.proto:
##########
@@ -56,7 +56,7 @@ message GetResponse {
 }
 
 message ListRequest {
-    banyandb.common.v1.Metadata contaner = 1;
+    banyandb.common.v1.Metadata container = 1;

Review Comment:
   I see, and I wonder is "make generate" at root directory all i need to do ? By the way, if i run "make generate", there are over a hundred files that have their format changed, most of which are removed with some whitespace lines in the "import" module. Is that ok?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] remGigo commented on a diff in pull request #127: Fix protobuf file typo

Posted by GitBox <gi...@apache.org>.
remGigo commented on code in PR #127:
URL: https://github.com/apache/skywalking-banyandb/pull/127#discussion_r887796084


##########
api/proto/banyandb/property/v1/rpc.proto:
##########
@@ -56,7 +56,7 @@ message GetResponse {
 }
 
 message ListRequest {
-    banyandb.common.v1.Metadata contaner = 1;
+    banyandb.common.v1.Metadata container = 1;

Review Comment:
   ![1654164745(1)](https://user-images.githubusercontent.com/49940663/171608063-b4057261-5056-4d15-8fea-6689e67e5fc1.png)
   emmm, this is the result of "make generate", it may adjust the format ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] hanahmily closed pull request #127: Fix protobuf file typo

Posted by GitBox <gi...@apache.org>.
hanahmily closed pull request #127: Fix protobuf  file typo
URL: https://github.com/apache/skywalking-banyandb/pull/127


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] hanahmily commented on pull request #127: Fix protobuf file typo

Posted by GitBox <gi...@apache.org>.
hanahmily commented on PR #127:
URL: https://github.com/apache/skywalking-banyandb/pull/127#issuecomment-1144771754

   Then you have to modify this reference https://github.com/apache/skywalking-banyandb/blob/main/banyand/liaison/grpc/property.go#L63


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org