Re; [PATCH] Wishes for adjustments in Apache 2.0

[Justin Erenkrantz <je...@ebuilt.com>]

On Fri, Apr 06, 2001 at 03:05:57AM +0200, Ralf S. Engelschall wrote:
> 
> o if a module wants to hook into the build system, it has to
>   provide its own config.m4. That's fine for modules which ship with Apache
>   2.0. For externally maintained modules this implies that the end-user has
>   GNU Autoconf installed.  This is both against the principle (Autoconf is a
>   developer tool) and makes life of end-users more complicated. Not to mention
>   the problems which arise if the end-users has a different version of
>   Autoconf installed.

Totally agree here.

> o configure --help shows a few lines with wrong indentation (--with-ssl,
>   --with-mpm, etc.) This should be lined up correctly.

I did the grunt work (see below) - someone with commit access can apply this 
(after verifying it works).  Most of my cosmetic patches seem to end up in a
black hole - not that I care very much...

> o On the httpd linker command line I get "-export-dynamic -export-dynamic
>   -export-dynamic -export-dynamic -export-dynamic -export-dynamic" under
>   FreeBSD.

I think Roy might have committed a fix for this.

> o If I unpack httpd-2_0_16-beta.tar.gz twice and in one copy
>   perform "./configure --enable-modules=most; make; make distclean"
>   the result is different from a fresh unpack:
>   $ diff -ru3 httpd-2_0_16.orig httpd-2_0_16
>   Most important: the "make distclean" also removed the top-level "configure"
>   script.  That should only happen on a "make realclean" (if exists) but never
>   on a "make distclean".

Yeah, I noticed that playing with 2.0.16.  Not good.  I may submit a patch 
for this if it still happens.  -- justin

Index: configure.in
===================================================================
RCS file: /home/cvspublic/httpd-2.0/configure.in,v
retrieving revision 1.142
diff -u -r1.142 configure.in
--- configure.in	2001/04/03 23:47:39	1.142
+++ configure.in	2001/04/06 01:27:58
@@ -152,7 +152,7 @@
         [if test "$withval" = "yes"; then AC_MSG_ERROR('option --with-port requires a value (the TCP port number)'); else PORT="$withval"; fi],
 	[PORT=80])
 
-AC_ARG_ENABLE(debug,[  --enable-debug            Turn on debugging and compile time warnings],
+AC_ARG_ENABLE(debug,[  --enable-debug          Turn on debugging and compile time warnings],
         [CFLAGS="$CFLAGS -g"; if test "$GCC" = "yes"; then CFLAGS="$CFLAGS -Wall"; fi])
 
 AC_ARG_ENABLE(maintainer-mode,[  --enable-maintainer-mode  Turn on debugging and compile time warnings],
Index: modules/tls/config.m4
===================================================================
RCS file: /home/cvspublic/httpd-2.0/modules/tls/config.m4,v
retrieving revision 1.3
diff -u -r1.3 config.m4
--- modules/tls/config.m4	2001/02/12 16:50:21	1.3
+++ modules/tls/config.m4	2001/04/06 01:27:58
@@ -4,7 +4,7 @@
 tls_objs="mod_tls.lo openssl_state_machine.lo"
 
 APACHE_MODULE(tls, TLS/SSL support, $tls_objs, , no, [
-  AC_ARG_WITH(ssl,   [ --with-ssl      use a specific SSL library installation ],
+  AC_ARG_WITH(ssl,   [  --with-ssl              use a specific SSL library installation ],
   [
       searchfile="$withval/inc/ssl.h"
       if test -f $searchfile ; then
Index: server/mpm/config.m4
===================================================================
RCS file: /home/cvspublic/httpd-2.0/server/mpm/config.m4,v
retrieving revision 1.34
diff -u -r1.34 config.m4
--- server/mpm/config.m4	2001/04/03 18:37:07	1.34
+++ server/mpm/config.m4	2001/04/06 01:27:58
@@ -1,7 +1,7 @@
 AC_MSG_CHECKING(which MPM to use)
 AC_ARG_WITH(mpm,
 [  --with-mpm=MPM          Choose the process model for Apache to use.
-               MPM={beos,threaded,prefork,spmt_os2,perchild}],[
+                          MPM={beos,threaded,prefork,spmt_os2,perchild}],[
   APACHE_MPM=$withval
 ],[
   if test "x$APACHE_MPM" = "x"; then