You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Qifan Chen (Code Review)" <ge...@cloudera.org> on 2020/08/12 20:49:04 UTC

[Impala-ASF-CR] WIP IMPALA-7779 Parquet Scanner can write binary data into profile

Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16331


Change subject: WIP IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................

WIP IMPALA-7779 Parquet Scanner can write binary data into profile

This fix addresses the current limitation in that an ill-formatted
Parquet version string is not properly formatted before appearing
in an error message or impalad.INFO. With the fix, any such string is
converted to a hex string prefixed with 0x and each character is
represented by two hex digits.

Testing:
 "core" test (TBD).

Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
---
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M common/thrift/generate_error_codes.py
2 files changed, 12 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/16331/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 1
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] WIP IMPALA-7779 Parquet Scanner can write binary data into profile

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 )

Change subject: WIP IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6912/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Aug 2020 14:28:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16331 )

Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................

IMPALA-7779 Parquet Scanner can write binary data into profile

This fix addresses the current limitation in that an ill-formatted
Parquet version string is not properly formatted before appearing
in an error message or impalad.INFO. With the fix, any such string is
converted to a hex string first. The hex string is a sequence of
four hex digit groups separated by spaces and each group is one or
two hex digits, such as "6c 65 2e a".

Testing:
 Ran "core" tests successfully.

Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Reviewed-on: http://gerrit.cloudera.org:8080/16331
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Sahil Takiar <st...@cloudera.com>
---
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M common/thrift/generate_error_codes.py
M testdata/workloads/functional-query/queries/QueryTest/parquet.test
3 files changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Sahil Takiar: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 7
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 )

Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6968/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Aug 2020 13:01:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16331 )

Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................

IMPALA-7779 Parquet Scanner can write binary data into profile

This fix addresses the current limitation in that an ill-formatted
Parquet version string is not properly formatted before appearing
in an error message or impalad.INFO. With the fix, any such string is
converted to a hex string first. The hex string is a sequence of
four hex digit groups separated by spaces and each group is one or
two hex digits, such as "6c 65 2e a".

Testing:
 Ran "core" tests successfully.

Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
---
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M common/thrift/generate_error_codes.py
M testdata/workloads/functional-query/queries/QueryTest/parquet.test
3 files changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/16331/3
-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/16331 )

Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................

IMPALA-7779 Parquet Scanner can write binary data into profile

This fix addresses the current limitation in that an ill-formatted
Parquet version string is not properly formatted before appearing
in an error message or impalad.INFO. With the fix, any such string is
converted to a hex string first. The hex string is a sequence of
four hex digit groups separated by spaces and each group is one or
two hex digits, such as "6c 65 2e a".

Testing:
 Ran "core" tests successfully.

Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
---
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M common/thrift/generate_error_codes.py
M testdata/workloads/functional-query/queries/QueryTest/parquet.test
3 files changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/16331/5
-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 )

Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6293/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Aug 2020 17:18:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 )

Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 6
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Aug 2020 22:43:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 )

Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6930/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Aug 2020 16:45:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP IMPALA-7779 Parquet Scanner can write binary data into profile

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 )

Change subject: WIP IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................


Patch Set 1:

(1 comment)

overall, looks correct. would be nice to have a test for this as well.

http://gerrit.cloudera.org:8080/#/c/16331/1/be/src/exec/parquet/hdfs-parquet-scanner.cc
File be/src/exec/parquet/hdfs-parquet-scanner.cc:

http://gerrit.cloudera.org:8080/#/c/16331/1/be/src/exec/parquet/hdfs-parquet-scanner.cc@1337
PS1, Line 1337:   char hex[2 * sizeof(PARQUET_VERSION_NUMBER) + 2];
              :     hex[0] = '0';
              :     hex[1] = 'x';
              :     auto hex_ptr = hex + 2;
              :     for (int i = 0; i < sizeof(PARQUET_VERSION_NUMBER); i++) {
              :       sprintf(hex_ptr + i * 2, "%02x", magic_number_ptr[i]);
              :     }
              :     return Status(TErrorCode::PARQUET_BAD_VERSION_NUMBER, filename(),
              :         string(hex, sizeof(hex)), scan_node_->hdfs_table()->fully_qualified_name());
you can just use "ReadWriteUtil::HexDump" - we do something very similar in HdfsAvroScanner::ReadFileHeader



-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 1
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Aug 2020 21:27:39 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 )

Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Aug 2020 17:18:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 )

Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Aug 2020 17:18:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 )

Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6318/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 6
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Aug 2020 17:37:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 )

Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 6
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 15:41:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7779 Parquet Scanner can write binary data into profile

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 )

Change subject: IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6293/


-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Aug 2020 22:27:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP IMPALA-7779 Parquet Scanner can write binary data into profile

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16331 )

Change subject: WIP IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................

WIP IMPALA-7779 Parquet Scanner can write binary data into profile

This fix addresses the current limitation in that an ill-formatted
Parquet version string is not properly formatted before appearing
in an error message or impalad.INFO. With the fix, any such string is
converted to a hex string first.

Testing:
 "core" test (TBD).

Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
---
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M common/thrift/generate_error_codes.py
2 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/16331/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] WIP IMPALA-7779 Parquet Scanner can write binary data into profile

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 )

Change subject: WIP IMPALA-7779 Parquet Scanner can write binary data into profile
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6899/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Gerrit-Change-Number: 16331
Gerrit-PatchSet: 1
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Aug 2020 21:10:50 +0000
Gerrit-HasComments: No