You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "findepi (via GitHub)" <gi...@apache.org> on 2024/07/26 11:52:11 UTC
[PR] Update baseline gradle plugin to 5.58.0 [iceberg]
findepi opened a new pull request, #10788:
URL: https://github.com/apache/iceberg/pull/10788
Among other things, this pulls newest version of error-prone which adds
new useful checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Update baseline gradle plugin to 5.58.0 [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #10788:
URL: https://github.com/apache/iceberg/pull/10788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update baseline gradle plugin to 5.58.0 [iceberg]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on PR #10788:
URL: https://github.com/apache/iceberg/pull/10788#issuecomment-2252848242
i think it depends on the other. we can update only after we drop 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update baseline gradle plugin to 5.58.0 [iceberg]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on PR #10788:
URL: https://github.com/apache/iceberg/pull/10788#issuecomment-2265196428
Yes! let me rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Update baseline gradle plugin to 5.58.0 [iceberg]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on code in PR #10788:
URL: https://github.com/apache/iceberg/pull/10788#discussion_r1701801091
##########
baseline.gradle:
##########
@@ -86,11 +86,17 @@ subprojects {
'-Xep:CollectionUndefinedEquality:ERROR',
// specific to Palantir - Uses name `log` but we use name `LOG`
'-Xep:ConsistentLoggerName:OFF',
+ // TODO this is a recently added check. Figure out whether we adjust the code or suppress for good
Review Comment:
Created https://github.com/apache/iceberg/issues/10853, https://github.com/apache/iceberg/issues/10854, https://github.com/apache/iceberg/issues/10855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Update baseline gradle plugin to 5.58.0 [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #10788:
URL: https://github.com/apache/iceberg/pull/10788#discussion_r1701771289
##########
baseline.gradle:
##########
@@ -86,11 +86,17 @@ subprojects {
'-Xep:CollectionUndefinedEquality:ERROR',
// specific to Palantir - Uses name `log` but we use name `LOG`
'-Xep:ConsistentLoggerName:OFF',
+ // TODO this is a recently added check. Figure out whether we adjust the code or suppress for good
Review Comment:
> Alternatively, we can open up separate issues and mark them as good first issue to give other people a chance to contribute here
I like that 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update baseline gradle plugin to 5.58.0 [iceberg]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on PR #10788:
URL: https://github.com/apache/iceberg/pull/10788#issuecomment-2252599242
Draft -- currently depends on https://github.com/apache/iceberg/pull/10518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update baseline gradle plugin to 5.58.0 [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #10788:
URL: https://github.com/apache/iceberg/pull/10788#discussion_r1701765159
##########
baseline.gradle:
##########
@@ -86,11 +86,17 @@ subprojects {
'-Xep:CollectionUndefinedEquality:ERROR',
// specific to Palantir - Uses name `log` but we use name `LOG`
'-Xep:ConsistentLoggerName:OFF',
+ // TODO this is a recently added check. Figure out whether we adjust the code or suppress for good
Review Comment:
I believe we should probably address all of these and then configure them to `ERROR`.
Do you have a rough idea of how big the diff would be when addressing all of the new error prone checks? I think if it's not too much then we can include it in this PR.
Alternatively, we can open up separate issues and mark them as `good first issue` to give other people a chance to contribute here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update baseline gradle plugin to 5.58.0 [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #10788:
URL: https://github.com/apache/iceberg/pull/10788#issuecomment-2264914125
@findepi time to revisit this? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org