[GitHub] [netbeans] errael commented on pull request #5989: #5987: Use the currently active dialog as the presenter parent

["errael (via GitHub)" <gi...@apache.org>]

errael commented on PR #5989:
URL: https://github.com/apache/netbeans/pull/5989#issuecomment-1563213030

   > We could also simplify the `Frame` vs. `Window` logic
   
   Another possible simplification:
   Could the two branches of
   ```
   if (descriptor instanceof DialogDescriptor) {
   } else {
   }
   ```
   be collapsed into a single branch by prefacing the unified branch with something like
   ```
   createPresenter = descriptor instanceof DialogDescriptor
       ? (bunch_of_args) -> { return new NbDialog(needed_args); }
       : (bunch_of_args) -> { return new NbPresenter(needed_args); }
   ```
   and using `createPresenter.create(args)` as needed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists