[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #5584: Introduce file writer strategies for Parquet writer

["comphead (via GitHub)" <gi...@apache.org>]

comphead commented on code in PR #5584:
URL: https://github.com/apache/arrow-datafusion/pull/5584#discussion_r1137794244


##########
datafusion/core/src/dataframe.rs:
##########
@@ -930,10 +932,11 @@ impl DataFrame {
         self,
         path: &str,
         writer_properties: Option<WriterProperties>,
+        save_mode: FileWriterSaveMode,

Review Comment:
   That is good point, alternatively for parquet we can reuse `WriterProperties::key_value_metadata` to specify optional saveMode and default to some value in case of None



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org