You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "anjiahao1 (via GitHub)" <gi...@apache.org> on 2024/10/13 09:32:32 UTC
[PR] modlib:bug fix,allow 64bit elf load and if sym is NULL not load symbol [nuttx]
anjiahao1 opened a new pull request, #14205:
URL: https://github.com/apache/nuttx/pull/14205
## Summary
modlib bug fix
1. allow 64bit elf load
2. so need export symbols, exec elf don't need export symbols
## Impact
modlib
## Testing
`rv-virt:knsh` and `rv-virt:knsh64` with ostest and getprime, pass it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] modlib:bug fix,allow 64bit elf load and if sym is NULL not load symbol [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #14205:
URL: https://github.com/apache/nuttx/pull/14205#issuecomment-2408903558
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
**No, this PR does not meet the NuttX requirements.**
Here's why and how to improve it:
* **Insufficient Summary:**
* **Vague Description:** "modlib bug fix" is too general. Clearly state the bug the PR fixes. For example, "Fix modlib's inability to load 64-bit ELF files".
* **Missing Explanation:** Explain *why* exporting symbols is necessary for 64-bit ELF loading but not for regular ELF execution.
* **No References:** Link any relevant NuttX Issues that this PR addresses.
* **Incomplete Impact:**
* **Which Feature?** Be specific about the modlib feature impacted (e.g., "ELF loading functionality").
* **User Impact:** Will users need to make any changes to their code or configuration due to this fix? Be explicit.
* **Build/Hardware/Documentation:** Even if the answer is "NO" for most impact categories, state it explicitly for clarity.
* **Inadequate Testing:**
* **Insufficient Detail:** "rv-virt:knsh" is not descriptive enough. Specify the exact NuttX configuration (board, architecture) and versions used.
* **Missing Logs:** Provide actual testing logs *before* and *after* the change. Demonstrate the bug and its resolution.
* **Limited Scope:** Ideally, test on more than one platform/configuration to ensure the fix doesn't introduce regressions.
**How to Improve the PR:**
1. **Expand the Summary:** Provide a clear, concise, and informative description of the bug, the solution, and its rationale.
2. **Complete the Impact Analysis:** Address all impact categories specifically, even if it's to say "NO" with a brief justification.
3. **Provide Detailed Testing Information:** Specify the exact test environments, include relevant log snippets, and consider expanding test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] modlib:bug fix,allow 64bit elf load and if sym is NULL not load symbol [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #14205:
URL: https://github.com/apache/nuttx/pull/14205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] modlib:bug fix,allow 64bit elf load and if sym is NULL not load symbol [nuttx]
Posted by "anjiahao1 (via GitHub)" <gi...@apache.org>.
anjiahao1 commented on PR #14205:
URL: https://github.com/apache/nuttx/pull/14205#issuecomment-2409843357
look like ci build break

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] modlib:bug fix,allow 64bit elf load and if sym is NULL not load symbol [nuttx]
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #14205:
URL: https://github.com/apache/nuttx/pull/14205#issuecomment-2409854412
@anjiahao1 The build should be fixed by https://github.com/apache/nuttx-apps/pull/2716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org