[GitHub] efine opened a new pull request #1095: Allow override of `-args_file` and `-config` parameters

[GitBox <gi...@apache.org>]

efine opened a new pull request #1095: Allow override of `-args_file` and `-config` parameters
URL: https://github.com/apache/couchdb/pull/1095
 
 
   ## Overview
   
   The existing `couchdb` start script hard-codes the arguments to
   `-args_file` and `-config`. Although it is possible to copy this
   script and modify it, or modify it in place, that is less than ideal
   and can lead to all kinds of difficulties.
   
   This PR adds the following environment variables:
   
   - `ARGS_FILE`: By default, set to the existing hard-coded value.
   - `SYSCONFIG_FILE`: By default, set to the existing hard-coded value.
   - `COUCHDB_ARGS_FILE`: If non-empty, overrides `$ARGS_FILE`.
   - `COUCHDB_SYSCONFIG_FILE`: If non-empty, overrides `$SYSCONFIG_FILE`.
   
   By changing the script to use these environment variables, it makes it easily possible
   to use different settings without tinkering with the pristine installed CouchDB environment.
   
   Kindly consider this feature request as a useful, and "mostly harmless" addition to CouchDB.
   
   ## Testing recommendations
   
   This pull request is designed to be completely backward-compatible with the existing `couchdb` script.
   
   Testing can be very simple:
   
   1. Run without any environment changes - should do precisely what the existing start script does.
   2. Run as `COUCHDB_ARGS_FILE=/some/different/vm.args couchdb` - should use the args from the specified `vm.args`.
   3. Run as `COUCHDB_SYSCONFIG_FILE=/some/different/sys.config couchdb` - should use the configuration in the specified `sys.config`.
   4. Run with both overrides - should be a combination of the above two tests.
   
   ## Related Issues or Pull Requests
   
   PR apache/couchdb-documentation#227
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [ ] Changes are covered by tests;
   - [x] Documentation reflects the changes;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services