You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2017/04/26 23:38:25 UTC

Review Request 58759: Introduced SecretFetcher module interface.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/
-----------------------------------------------------------

Review request for mesos and Gilbert Song.


Repository: mesos


Description
-------

Introduced SecretFetcher module interface.


Diffs
-----

  include/mesos/module/secretfetcher.hpp PRE-CREATION 
  include/mesos/secret/secretfetcher.hpp PRE-CREATION 
  src/Makefile.am 1fc453c497f278c9fc3fa5e91eb720a932915fde 
  src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 


Diff: https://reviews.apache.org/r/58759/diff/1/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 58759: Introduced SecretFetcher module interface.

Posted by Kapil Arya <ka...@mesosphere.io>.


> On May 4, 2017, 6:25 p.m., Jie Yu wrote:
> > include/mesos/secret/fetcher.hpp
> > Lines 17 (patched)
> > <https://reviews.apache.org/r/58759/diff/3/?file=1708762#file1708762line17>
> >
> >     I'd put the file to include/mesos/fetcher/secret_fetcher.hpp

I am not sure so sure about it because there is nothing in common between `Fetcher` and `SecretFetcher`. One can think of `SecretFetcher` as more like secret-resolver.

Perhaps, next to authentication/secret_generator.hpp would be slightly better, but then it doesn't have much to do with authentication either.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review173966
-----------------------------------------------------------


On May 4, 2017, 4:06 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 4:06 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced SecretFetcher module interface.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module/secretfetcher.hpp PRE-CREATION 
>   include/mesos/secret/fetcher.hpp PRE-CREATION 
>   src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
>   src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 
> 
> 
> Diff: https://reviews.apache.org/r/58759/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58759: Introduced SecretFetcher module interface.

Posted by Jie Yu <yu...@gmail.com>.


> On May 4, 2017, 10:25 p.m., Jie Yu wrote:
> > include/mesos/secret/fetcher.hpp
> > Lines 17 (patched)
> > <https://reviews.apache.org/r/58759/diff/3/?file=1708762#file1708762line17>
> >
> >     I'd put the file to include/mesos/fetcher/secret_fetcher.hpp
> 
> Kapil Arya wrote:
>     I am not sure so sure about it because there is nothing in common between `Fetcher` and `SecretFetcher`. One can think of `SecretFetcher` as more like secret-resolver.
>     
>     Perhaps, next to authentication/secret_generator.hpp would be slightly better, but then it doesn't have much to do with authentication either.

OK, i am fine with secret/fetcher.hpp. Make sure it's consistent with the cpp file.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review173966
-----------------------------------------------------------


On May 4, 2017, 8:06 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 8:06 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced SecretFetcher module interface.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module/secretfetcher.hpp PRE-CREATION 
>   include/mesos/secret/fetcher.hpp PRE-CREATION 
>   src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
>   src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 
> 
> 
> Diff: https://reviews.apache.org/r/58759/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58759: Introduced SecretFetcher module interface.

Posted by Kapil Arya <ka...@mesosphere.io>.


> On May 4, 2017, 6:25 p.m., Jie Yu wrote:
> > include/mesos/module/secretfetcher.hpp
> > Lines 17 (patched)
> > <https://reviews.apache.org/r/58759/diff/3/?file=1708761#file1708761line17>
> >
> >     secret_fetcher.hpp
> >     
> >     (we have secret_generator.hpp). Let's make sure it's consistent.

I'll update it to secret_fetcher.hpp. However, please note that there is still some inconsistency here: the module interface is called `SecretGenerator` but the file is named `secret_generator.hpp`.


> On May 4, 2017, 6:25 p.m., Jie Yu wrote:
> > include/mesos/secret/fetcher.hpp
> > Lines 17 (patched)
> > <https://reviews.apache.org/r/58759/diff/3/?file=1708762#file1708762line17>
> >
> >     I'd put the file to include/mesos/fetcher/secret_fetcher.hpp
> 
> Kapil Arya wrote:
>     I am not sure so sure about it because there is nothing in common between `Fetcher` and `SecretFetcher`. One can think of `SecretFetcher` as more like secret-resolver.
>     
>     Perhaps, next to authentication/secret_generator.hpp would be slightly better, but then it doesn't have much to do with authentication either.
> 
> Jie Yu wrote:
>     OK, i am fine with secret/fetcher.hpp. Make sure it's consistent with the cpp file.

I am not sure what you mean by "Make sure it's consistent with the cpp file"?


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review173966
-----------------------------------------------------------


On May 4, 2017, 4:06 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 4:06 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced SecretFetcher module interface.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module/secretfetcher.hpp PRE-CREATION 
>   include/mesos/secret/fetcher.hpp PRE-CREATION 
>   src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
>   src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 
> 
> 
> Diff: https://reviews.apache.org/r/58759/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58759: Introduced SecretFetcher module interface.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review173966
-----------------------------------------------------------




include/mesos/module/secretfetcher.hpp
Lines 17 (patched)
<https://reviews.apache.org/r/58759/#comment247059>

    secret_fetcher.hpp
    
    (we have secret_generator.hpp). Let's make sure it's consistent.



include/mesos/secret/fetcher.hpp
Lines 17 (patched)
<https://reviews.apache.org/r/58759/#comment247060>

    I'd put the file to include/mesos/fetcher/secret_fetcher.hpp


- Jie Yu


On May 4, 2017, 8:06 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 8:06 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced SecretFetcher module interface.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module/secretfetcher.hpp PRE-CREATION 
>   include/mesos/secret/fetcher.hpp PRE-CREATION 
>   src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
>   src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 
> 
> 
> Diff: https://reviews.apache.org/r/58759/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58759: Introduced SecretResolver module interface.

Posted by Gilbert Song <so...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review174911
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On May 12, 2017, 10:52 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> -----------------------------------------------------------
> 
> (Updated May 12, 2017, 10:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced SecretResolver module interface.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module.hpp c28d01df54906b2b8ebfe7ac9e719a0d1be45614 
>   include/mesos/module/secret_resolver.hpp PRE-CREATION 
>   include/mesos/secret/resolver.hpp PRE-CREATION 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 
> 
> 
> Diff: https://reviews.apache.org/r/58759/diff/8/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58759: Introduced SecretResolver module interface.

Posted by Gilbert Song <so...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review174912
-----------------------------------------------------------




include/mesos/secret/resolver.hpp
Lines 26-35 (patched)
<https://reviews.apache.org/r/58759/#comment248182>

    Did we try to get rid of the c style comments:
    ```
    /**
     *
     */
    ```
    
    and insist on c++ ctyle comments:
    ```
    //
    //
    //
    ```
    
    ditto to the others.


- Gilbert Song


On May 12, 2017, 10:52 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> -----------------------------------------------------------
> 
> (Updated May 12, 2017, 10:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced SecretResolver module interface.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module.hpp c28d01df54906b2b8ebfe7ac9e719a0d1be45614 
>   include/mesos/module/secret_resolver.hpp PRE-CREATION 
>   include/mesos/secret/resolver.hpp PRE-CREATION 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 
> 
> 
> Diff: https://reviews.apache.org/r/58759/diff/8/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58759: Introduced SecretResolver module interface.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review175322
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On May 16, 2017, 7:22 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> -----------------------------------------------------------
> 
> (Updated May 16, 2017, 7:22 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced SecretResolver module interface.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module.hpp c28d01df54906b2b8ebfe7ac9e719a0d1be45614 
>   include/mesos/module/secret_resolver.hpp PRE-CREATION 
>   include/mesos/secret/resolver.hpp PRE-CREATION 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 
> 
> 
> Diff: https://reviews.apache.org/r/58759/diff/9/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58759: Introduced SecretResolver module interface.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/
-----------------------------------------------------------

(Updated May 16, 2017, 3:22 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
-------

Addressed Gilbert's comments.


Bugs: MESOS-7418
    https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description
-------

Introduced SecretResolver module interface.


Diffs (updated)
-----

  include/mesos/module.hpp c28d01df54906b2b8ebfe7ac9e719a0d1be45614 
  include/mesos/module/secret_resolver.hpp PRE-CREATION 
  include/mesos/secret/resolver.hpp PRE-CREATION 
  src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
  src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 


Diff: https://reviews.apache.org/r/58759/diff/9/

Changes: https://reviews.apache.org/r/58759/diff/8-9/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 58759: Introduced SecretResolver module interface.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/
-----------------------------------------------------------

(Updated May 12, 2017, 1:52 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
-------

rebased


Bugs: MESOS-7418
    https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description
-------

Introduced SecretResolver module interface.


Diffs (updated)
-----

  include/mesos/module.hpp c28d01df54906b2b8ebfe7ac9e719a0d1be45614 
  include/mesos/module/secret_resolver.hpp PRE-CREATION 
  include/mesos/secret/resolver.hpp PRE-CREATION 
  src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
  src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 


Diff: https://reviews.apache.org/r/58759/diff/8/

Changes: https://reviews.apache.org/r/58759/diff/7-8/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 58759: Introduced SecretResolver module interface.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/
-----------------------------------------------------------

(Updated May 9, 2017, 2:10 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
-------

Addressed Vinod's comments!


Bugs: MESOS-7418
    https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description
-------

Introduced SecretResolver module interface.


Diffs (updated)
-----

  include/mesos/module.hpp c28d01df54906b2b8ebfe7ac9e719a0d1be45614 
  include/mesos/module/secret_resolver.hpp PRE-CREATION 
  include/mesos/secret/resolver.hpp PRE-CREATION 
  src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
  src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 


Diff: https://reviews.apache.org/r/58759/diff/7/

Changes: https://reviews.apache.org/r/58759/diff/6-7/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 58759: Introduced SecretResolver module interface.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review174238
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/module.hpp
Lines 113 (patched)
<https://reviews.apache.org/r/58759/#comment247349>

    s/to during/during/ ?



include/mesos/secret/resolver.hpp
Lines 30 (patched)
<https://reviews.apache.org/r/58759/#comment247350>

    s/::value/::Value/



include/mesos/secret/resolver.hpp
Lines 31 (patched)
<https://reviews.apache.org/r/58759/#comment247351>

    s/cannot/secret cannot/



include/mesos/secret/resolver.hpp
Lines 41 (patched)
<https://reviews.apache.org/r/58759/#comment247352>

    s/instanciated/instantiated/



include/mesos/secret/resolver.hpp
Lines 42-47 (patched)
<https://reviews.apache.org/r/58759/#comment247353>

    Do we typically talk about default implementations here?



include/mesos/secret/resolver.hpp
Lines 54 (patched)
<https://reviews.apache.org/r/58759/#comment247354>

    s/to a/a/


- Vinod Kone


On May 8, 2017, 10:19 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> -----------------------------------------------------------
> 
> (Updated May 8, 2017, 10:19 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced SecretResolver module interface.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module.hpp c28d01df54906b2b8ebfe7ac9e719a0d1be45614 
>   include/mesos/module/secret_resolver.hpp PRE-CREATION 
>   include/mesos/secret/resolver.hpp PRE-CREATION 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 
> 
> 
> Diff: https://reviews.apache.org/r/58759/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58759: Introduced SecretResolver module interface.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/
-----------------------------------------------------------

(Updated May 8, 2017, 6:19 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
-------

Rebased


Bugs: MESOS-7418
    https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description
-------

Introduced SecretResolver module interface.


Diffs (updated)
-----

  include/mesos/module.hpp c28d01df54906b2b8ebfe7ac9e719a0d1be45614 
  include/mesos/module/secret_resolver.hpp PRE-CREATION 
  include/mesos/secret/resolver.hpp PRE-CREATION 
  src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
  src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 


Diff: https://reviews.apache.org/r/58759/diff/6/

Changes: https://reviews.apache.org/r/58759/diff/5-6/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 58759: Introduced SecretResolver module interface.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/
-----------------------------------------------------------

(Updated May 5, 2017, 8:31 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
-------

Added comments/TODO about unique_ptr for `ModuleManager::create`.


Bugs: MESOS-7418
    https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description
-------

Introduced SecretResolver module interface.


Diffs (updated)
-----

  include/mesos/module.hpp c28d01df54906b2b8ebfe7ac9e719a0d1be45614 
  include/mesos/module/secret_resolver.hpp PRE-CREATION 
  include/mesos/secret/resolver.hpp PRE-CREATION 
  src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
  src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 


Diff: https://reviews.apache.org/r/58759/diff/5/

Changes: https://reviews.apache.org/r/58759/diff/4-5/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 58759: Introduced SecretResolver module interface.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/
-----------------------------------------------------------

(Updated May 5, 2017, 6:37 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
-------

Renamed SecretFetcher to SecretResolver.


Summary (updated)
-----------------

Introduced SecretResolver module interface.


Bugs: MESOS-7418
    https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description (updated)
-------

Introduced SecretResolver module interface.


Diffs (updated)
-----

  include/mesos/module/secret_resolver.hpp PRE-CREATION 
  include/mesos/secret/resolver.hpp PRE-CREATION 
  src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
  src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 


Diff: https://reviews.apache.org/r/58759/diff/4/

Changes: https://reviews.apache.org/r/58759/diff/3-4/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 58759: Introduced SecretFetcher module interface.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/
-----------------------------------------------------------

(Updated May 4, 2017, 4:06 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
-------

Addressed Vinod's comments.


Bugs: MESOS-7418
    https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description
-------

Introduced SecretFetcher module interface.


Diffs (updated)
-----

  include/mesos/module/secretfetcher.hpp PRE-CREATION 
  include/mesos/secret/fetcher.hpp PRE-CREATION 
  src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
  src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 


Diff: https://reviews.apache.org/r/58759/diff/3/

Changes: https://reviews.apache.org/r/58759/diff/2-3/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 58759: Introduced SecretFetcher module interface.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review173514
-----------------------------------------------------------




include/mesos/secret/secretfetcher.hpp
Lines 27 (patched)
<https://reviews.apache.org/r/58759/#comment246504>

    Should this be just called `Fetcher` since it is in the `secret` namespace already? Looks like this is how URI, APPC etc fetchers are named.


- Vinod Kone


On April 28, 2017, 6:50 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> -----------------------------------------------------------
> 
> (Updated April 28, 2017, 6:50 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced SecretFetcher module interface.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module/secretfetcher.hpp PRE-CREATION 
>   include/mesos/secret/secretfetcher.hpp PRE-CREATION 
>   src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
>   src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 
> 
> 
> Diff: https://reviews.apache.org/r/58759/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58759: Introduced SecretFetcher module interface.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/
-----------------------------------------------------------

(Updated April 28, 2017, 2:50 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Bugs: MESOS-7418
    https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description
-------

Introduced SecretFetcher module interface.


Diffs (updated)
-----

  include/mesos/module/secretfetcher.hpp PRE-CREATION 
  include/mesos/secret/secretfetcher.hpp PRE-CREATION 
  src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
  src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 


Diff: https://reviews.apache.org/r/58759/diff/2/

Changes: https://reviews.apache.org/r/58759/diff/1-2/


Testing
-------


Thanks,

Kapil Arya