[GitHub] spark pull request: [SPARK-2873] [SQL] using ExternalAppendOnlyMap...

[marmbrus <gi...@git.apache.org>]

Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1822#discussion_r16007101
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/AggregatesSuite.scala ---
    @@ -0,0 +1,70 @@
    +package org.apache.spark.sql.catalyst.expressions
    +
    +import org.scalatest.FunSuite
    +import org.apache.spark.sql.catalyst.types._
    +import org.apache.spark.sql.catalyst.dsl.expressions._
    +
    +
    +class AggregatesSuite extends FunSuite {
    +
    +  val testRows = Seq(1,1,2,2,3,3,4,4).map(x => {
    +    val row = new GenericMutableRow(1)
    +    row(0) = x
    +    row
    +  })
    +
    +  val dataType: DataType = IntegerType
    +
    +  val exp = BoundReference(0,dataType,true)
    +
    +  def checkMethod(f:AggregateExpression) = {
    --- End diff --
    
    Space after `:`.  Can you add some scala doc about what this is checking?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org