[GitHub] [arrow-datafusion] aprimadi commented on a diff in pull request #6270: Handle binary op interval in logical AST builder

["aprimadi (via GitHub)" <gi...@apache.org>]

aprimadi commented on code in PR #6270:
URL: https://github.com/apache/arrow-datafusion/pull/6270#discussion_r1186828851


##########
datafusion/sql/src/expr/value.rs:
##########
@@ -160,9 +161,17 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
         }
     }
 
+    /// Convert a SQL interval expression to a DataFusion logical plan
+    /// expression
+    ///
+    /// Waiting for this issue to be resolved:
+    /// https://github.com/sqlparser-rs/sqlparser-rs/issues/869
+    #[allow(clippy::too_many_arguments)]

Review Comment:
   Ignoring clippy for now rather than creating a temporary struct to pass to this function. See: https://github.com/sqlparser-rs/sqlparser-rs/issues/869



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org