You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Erin Noe-Payne <er...@mitre.org> on 2012/04/25 17:09:52 UTC
Review Request: Rave 563 - Bootstrap enable open-views popups
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4875/
-----------------------------------------------------------
Review request for rave.
Summary
-------
Bootstrap enable open-views popups
Rave 563 (https://issues.apache.org/jira/browse/RAVE-563)
Diffs
-----
trunk/rave-demo-gadgets/src/main/webapp/open_views_demo.xml 1329874
trunk/rave-portal-resources/src/main/webapp/css/rave.css 1329874
trunk/rave-portal-resources/src/main/webapp/script/rave.js 1329874
Diff: https://reviews.apache.org/r/4875/diff
Testing
-------
Tested in chrome, ff, ie 8/9
Thanks,
Erin
Re: Review Request: Rave 563 - Bootstrap enable open-views popups
Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4875/#review7240
-----------------------------------------------------------
Ship it!
LGTM
- Anthony
On 2012-04-25 17:54:24, Erin Noe-Payne wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4875/
> -----------------------------------------------------------
>
> (Updated 2012-04-25 17:54:24)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> Bootstrap enable open-views popups
>
> Rave 563 (https://issues.apache.org/jira/browse/RAVE-563)
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/script/rave.js 1329874
> trunk/rave-demo-gadgets/src/main/webapp/open_views_demo.xml 1329874
> trunk/rave-portal-resources/src/main/webapp/css/rave.css 1329874
>
> Diff: https://reviews.apache.org/r/4875/diff
>
>
> Testing
> -------
>
> Tested in chrome, ff, ie 8/9
>
>
> Thanks,
>
> Erin
>
>
Re: Review Request: Rave 563 - Bootstrap enable open-views popups
Posted by Erin Noe-Payne <er...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4875/
-----------------------------------------------------------
(Updated 2012-04-25 17:54:24.800517)
Review request for rave.
Changes
-------
minor css update to make slideout view wider and visually consistent with bootstrap modals
Summary
-------
Bootstrap enable open-views popups
Rave 563 (https://issues.apache.org/jira/browse/RAVE-563)
Diffs (updated)
-----
trunk/rave-portal-resources/src/main/webapp/script/rave.js 1329874
trunk/rave-demo-gadgets/src/main/webapp/open_views_demo.xml 1329874
trunk/rave-portal-resources/src/main/webapp/css/rave.css 1329874
Diff: https://reviews.apache.org/r/4875/diff
Testing
-------
Tested in chrome, ff, ie 8/9
Thanks,
Erin