You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xerces.apache.org by mr...@apache.org on 2008/04/07 01:17:56 UTC
svn commit: r645327 - in /xerces/java/trunk/src/org/apache: html/dom/
xerces/dom/ xerces/impl/xs/
Author: mrglavas
Date: Sun Apr 6 16:17:54 2008
New Revision: 645327
URL: http://svn.apache.org/viewvc?rev=645327&view=rev
Log:
Fields storing singleton instances of DOMImplementation should be final.
Modified:
xerces/java/trunk/src/org/apache/html/dom/HTMLDOMImplementationImpl.java
xerces/java/trunk/src/org/apache/xerces/dom/ASDOMImplementationImpl.java
xerces/java/trunk/src/org/apache/xerces/dom/CoreDOMImplementationImpl.java
xerces/java/trunk/src/org/apache/xerces/dom/DOMImplementationImpl.java
xerces/java/trunk/src/org/apache/xerces/dom/DeferredDOMImplementationImpl.java
xerces/java/trunk/src/org/apache/xerces/dom/PSVIDOMImplementationImpl.java
xerces/java/trunk/src/org/apache/xerces/impl/xs/XSImplementationImpl.java
Modified: xerces/java/trunk/src/org/apache/html/dom/HTMLDOMImplementationImpl.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/src/org/apache/html/dom/HTMLDOMImplementationImpl.java?rev=645327&r1=645326&r2=645327&view=diff
==============================================================================
--- xerces/java/trunk/src/org/apache/html/dom/HTMLDOMImplementationImpl.java (original)
+++ xerces/java/trunk/src/org/apache/html/dom/HTMLDOMImplementationImpl.java Sun Apr 6 16:17:54 2008
@@ -45,7 +45,7 @@
* Holds a reference to the single instance of the DOM implementation.
* Only one instance is required since this class is multiple entry.
*/
- private static HTMLDOMImplementation _instance = new HTMLDOMImplementationImpl();
+ private static final HTMLDOMImplementation _instance = new HTMLDOMImplementationImpl();
/**
Modified: xerces/java/trunk/src/org/apache/xerces/dom/ASDOMImplementationImpl.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/src/org/apache/xerces/dom/ASDOMImplementationImpl.java?rev=645327&r1=645326&r2=645327&view=diff
==============================================================================
--- xerces/java/trunk/src/org/apache/xerces/dom/ASDOMImplementationImpl.java (original)
+++ xerces/java/trunk/src/org/apache/xerces/dom/ASDOMImplementationImpl.java Sun Apr 6 16:17:54 2008
@@ -50,7 +50,7 @@
// static
/** Dom implementation singleton. */
- static ASDOMImplementationImpl singleton = new ASDOMImplementationImpl();
+ static final ASDOMImplementationImpl singleton = new ASDOMImplementationImpl();
//
Modified: xerces/java/trunk/src/org/apache/xerces/dom/CoreDOMImplementationImpl.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/src/org/apache/xerces/dom/CoreDOMImplementationImpl.java?rev=645327&r1=645326&r2=645327&view=diff
==============================================================================
--- xerces/java/trunk/src/org/apache/xerces/dom/CoreDOMImplementationImpl.java (original)
+++ xerces/java/trunk/src/org/apache/xerces/dom/CoreDOMImplementationImpl.java Sun Apr 6 16:17:54 2008
@@ -91,8 +91,8 @@
// static
/** Dom implementation singleton. */
- static CoreDOMImplementationImpl singleton =
- new CoreDOMImplementationImpl();
+ static final CoreDOMImplementationImpl singleton = new CoreDOMImplementationImpl();
+
//
// Public methods
//
@@ -683,7 +683,7 @@
* SoftReferences which haven't yet been cleared by the garbage
* collector.
*/
- static class RevalidationHandlerHolder {
+ static final class RevalidationHandlerHolder {
RevalidationHandlerHolder(RevalidationHandler handler) {
this.handler = handler;
}
@@ -694,7 +694,7 @@
* A holder for XMLDTDLoaders. This allows us to reuse SoftReferences
* which haven't yet been cleared by the garbage collector.
*/
- static class XMLDTDLoaderHolder {
+ static final class XMLDTDLoaderHolder {
XMLDTDLoaderHolder(XMLDTDLoader loader) {
this.loader = loader;
}
Modified: xerces/java/trunk/src/org/apache/xerces/dom/DOMImplementationImpl.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/src/org/apache/xerces/dom/DOMImplementationImpl.java?rev=645327&r1=645326&r2=645327&view=diff
==============================================================================
--- xerces/java/trunk/src/org/apache/xerces/dom/DOMImplementationImpl.java (original)
+++ xerces/java/trunk/src/org/apache/xerces/dom/DOMImplementationImpl.java Sun Apr 6 16:17:54 2008
@@ -49,7 +49,7 @@
// static
/** Dom implementation singleton. */
- static DOMImplementationImpl singleton = new DOMImplementationImpl();
+ static final DOMImplementationImpl singleton = new DOMImplementationImpl();
//
Modified: xerces/java/trunk/src/org/apache/xerces/dom/DeferredDOMImplementationImpl.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/src/org/apache/xerces/dom/DeferredDOMImplementationImpl.java?rev=645327&r1=645326&r2=645327&view=diff
==============================================================================
--- xerces/java/trunk/src/org/apache/xerces/dom/DeferredDOMImplementationImpl.java (original)
+++ xerces/java/trunk/src/org/apache/xerces/dom/DeferredDOMImplementationImpl.java Sun Apr 6 16:17:54 2008
@@ -42,7 +42,7 @@
// static
/** Dom implementation singleton. */
- static DeferredDOMImplementationImpl singleton = new DeferredDOMImplementationImpl();
+ static final DeferredDOMImplementationImpl singleton = new DeferredDOMImplementationImpl();
//
Modified: xerces/java/trunk/src/org/apache/xerces/dom/PSVIDOMImplementationImpl.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/src/org/apache/xerces/dom/PSVIDOMImplementationImpl.java?rev=645327&r1=645326&r2=645327&view=diff
==============================================================================
--- xerces/java/trunk/src/org/apache/xerces/dom/PSVIDOMImplementationImpl.java (original)
+++ xerces/java/trunk/src/org/apache/xerces/dom/PSVIDOMImplementationImpl.java Sun Apr 6 16:17:54 2008
@@ -46,7 +46,7 @@
// static
/** Dom implementation singleton. */
- static PSVIDOMImplementationImpl singleton = new PSVIDOMImplementationImpl();
+ static final PSVIDOMImplementationImpl singleton = new PSVIDOMImplementationImpl();
//
// Public methods
Modified: xerces/java/trunk/src/org/apache/xerces/impl/xs/XSImplementationImpl.java
URL: http://svn.apache.org/viewvc/xerces/java/trunk/src/org/apache/xerces/impl/xs/XSImplementationImpl.java?rev=645327&r1=645326&r2=645327&view=diff
==============================================================================
--- xerces/java/trunk/src/org/apache/xerces/impl/xs/XSImplementationImpl.java (original)
+++ xerces/java/trunk/src/org/apache/xerces/impl/xs/XSImplementationImpl.java Sun Apr 6 16:17:54 2008
@@ -47,7 +47,7 @@
// static
/** Dom implementation singleton. */
- static XSImplementationImpl singleton = new XSImplementationImpl();
+ static final XSImplementationImpl singleton = new XSImplementationImpl();
//
// Public methods
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@xerces.apache.org
For additional commands, e-mail: commits-help@xerces.apache.org