You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@pdfbox.apache.org by Guillaume Maillrd <gu...@ilm-informatique.fr> on 2024/03/15 12:45:32 UTC
Bugfix for FileSystemFontProvider
Hi,
In version 2.0.30, a typo in computeHash from FileSystemFontProvider
makes all hash to return "".
It breaks the cache logic, resulting a very slow loadDiskCache.
Please replace "SHA512" by "SHA-512" or backport the v3 code to use CRC32.
The "// never happens" comment looks funny.
Best regards,
Guillaume
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: users-help@pdfbox.apache.org
Re: Bugfix for FileSystemFontProvider
Posted by Guillaume Maillrd <gu...@ilm-informatique.fr>.
Hi,
Thanks, sorry for this duplicate.
I hope 2.0.31 will be released soon.
Regards,
Guillaume
Le 15/03/2024 à 13:51, Tilman Hausherr a écrit :
> Hi,
>
> Yeah, "never happens" is a red flag. That part has been changed to use
> CRC32:
> https://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FileSystemFontProvider.java?revision=1916176&view=markup#l923
>
>
> https://issues.apache.org/jira/browse/PDFBOX-5727
>
> Tilman
>
> On 15.03.2024 13:45, Guillaume Maillrd wrote:
>> Hi,
>>
>> In version 2.0.30, a typo in computeHash from FileSystemFontProvider
>> makes all hash to return "".
>> It breaks the cache logic, resulting a very slow loadDiskCache.
>>
>> Please replace "SHA512" by "SHA-512" or backport the v3 code to use
>> CRC32.
>> The "// never happens" comment looks funny.
>>
>> Best regards,
>>
>> Guillaume
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@pdfbox.apache.org
>> For additional commands, e-mail: users-help@pdfbox.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@pdfbox.apache.org
> For additional commands, e-mail: users-help@pdfbox.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: users-help@pdfbox.apache.org
Re: Bugfix for FileSystemFontProvider
Posted by Tilman Hausherr <TH...@t-online.de>.
Hi,
Yeah, "never happens" is a red flag. That part has been changed to use
CRC32:
https://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FileSystemFontProvider.java?revision=1916176&view=markup#l923
https://issues.apache.org/jira/browse/PDFBOX-5727
Tilman
On 15.03.2024 13:45, Guillaume Maillrd wrote:
> Hi,
>
> In version 2.0.30, a typo in computeHash from FileSystemFontProvider
> makes all hash to return "".
> It breaks the cache logic, resulting a very slow loadDiskCache.
>
> Please replace "SHA512" by "SHA-512" or backport the v3 code to use
> CRC32.
> The "// never happens" comment looks funny.
>
> Best regards,
>
> Guillaume
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@pdfbox.apache.org
> For additional commands, e-mail: users-help@pdfbox.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: users-help@pdfbox.apache.org