You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/03/10 18:26:44 UTC

[GitHub] incubator-brooklyn pull request: Docs: improve rebind and Software...

GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/548

    Docs: improve rebind and SoftwareProcess docs

    We could also do with moving the persistence guidelines / best practices into somewhere more prominent (e.g. a top-level page)?
    
    This PR hopefully gives the content required.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn docs/improve-rebind-and-SoftwareProcess-docs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/548.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #548
    
----
commit 8527d7e0ba8351d9afb1aee1550ec3e7ac8c12bf
Author: Aled Sage <al...@gmail.com>
Date:   2015-03-10T16:54:52Z

    Docs: minor improvements
    
    - Improve tests.md
    - Fix formatting

commit 4ae4e6af1b4e7dfae8b898c9b4faff33aee48d7e
Author: Aled Sage <al...@gmail.com>
Date:   2015-03-10T17:24:07Z

    Docs: describe SoftwareProcess lifecycle

commit fe4668ccc05eb6e953de1d4172014d63efa462bd
Author: Aled Sage <al...@gmail.com>
Date:   2015-03-10T17:24:32Z

    Docs: persistence best practices / guidelines

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Docs: improve rebind and Software...

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/548#discussion_r26372473
  
    --- Diff: docs/guide/java/entities.md ---
    @@ -123,4 +121,90 @@ TODO more drivers such as jmx, etc are planned
     Testing
     -------
     
    -* Run in a mock ``SimulatedLocation``, defining new metaclass methods to be able to start there and assert the correct behaviour when that is invoked
    +* Unit tests can make use of `SimulatedLocation` and `TestEntity`, and can extend `BrooklynAppUnitTestSupport`.
    +* Integration tests and use a `LocalhostMachineProvisioningLocation`, and can also extend `BrooklynAppUnitTestSupport`.
    +
    +
    +<a name="SoftwareProcess-lifecycle"></a>
    --- End diff --
    
    links are now generated automatically by the doc tools, so these `<a ...` links can be removed i think.  you can even have menu-updates-as-you-scroll behaviour; see e.g. learn more -> features.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Docs: improve rebind and Software...

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/548#issuecomment-78882389
  
    good info, merging.
    
    i think persistence fits under operations, but should probably be linked from the java section, or maybe persistence should be split between java and ops, depending what is being covered. but hardly important exactly where, as long as it is there and not too hard to find.  would not move to a higher level -- everything is important at that higher level!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Docs: improve rebind and Software...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/548


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---