[jira] [Comment Edited] (CALCITE-972) Decimal data sent by Avatica cannot be interpreted by some clients

["Josh Elser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225153#comment-15225153 ] 

Josh Elser edited comment on CALCITE-972 at 4/4/16 10:04 PM:
-------------------------------------------------------------

FWIW, I ended up serializing decimals as strings w/ protobuf serialization in CALCITE-1103. Yay for consistent ideas.

I'm leaving this open, though, for the Rep.STRING and DecimalFromStringAccessor changes that Julian mentioned.


was (Author: elserj):
FWIW, I ended up serializing decimals as strings w/ protobuf serialization in CALCITE-1103. Yay for consistent ideas.

I'm leaving this open, though, for the Rep.STRING and DecimalFromStringAccessor Julian mentioned.

> Decimal data sent by Avatica cannot be interpreted by some clients
> ------------------------------------------------------------------
>
>                 Key: CALCITE-972
>                 URL: https://issues.apache.org/jira/browse/CALCITE-972
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>    Affects Versions: 1.5.0
>            Reporter: Kevin Liew
>            Assignee: Julian Hyde
>              Labels: decimal, double, wireprotocol
>
> JSON specifies a 'number' data type which does not differentiate between integer and floating-point values. The encoding for JSON numbers is implementation-specific. Libraries such as RapidJSON can treat all non-integer values as 'double' while still being compliant with JSON specifications. As a result, decimal values sent by Phoenix  will lose precision on the client side. 
> Decimal data should be sent as a string. If it is sent as a number, we cannot be expect that all JSON-spec compliant library will handle it properly. 
> ie. Phoenix sends a decimal as a JSON number, but Rapidjson can only  extract JSON numbers as integer or double because the C++ language does not have native decimal support. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)