You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/12/21 12:29:36 UTC

svn commit: r1896236 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/ASCIIHexFilter.java

Author: tilman
Date: Tue Dec 21 12:29:36 2021
New Revision: 1896236

URL: http://svn.apache.org/viewvc?rev=1896236&view=rev
Log:
PDFBOX-4892: remove unneeded positive check

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/ASCIIHexFilter.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/ASCIIHexFilter.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/ASCIIHexFilter.java?rev=1896236&r1=1896235&r2=1896236&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/ASCIIHexFilter.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/ASCIIHexFilter.java Tue Dec 21 12:29:36 2021
@@ -93,14 +93,11 @@ final class ASCIIHexFilter extends Filte
                 decoded.write(value);
                 break;
             }
-            if (secondByte >= 0) 
+            if (REVERSE_HEX[secondByte] == -1)
             {
-                if (REVERSE_HEX[secondByte] == -1)
-                {
-                    LOG.error("Invalid hex, int: " + secondByte + " char: " + (char)secondByte);
-                }
-                value += REVERSE_HEX[secondByte];
+                LOG.error("Invalid hex, int: " + secondByte + " char: " + (char) secondByte);
             }
+            value += REVERSE_HEX[secondByte];
             decoded.write(value);
         }
         decoded.flush();