[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

[BigCrunsh <gi...@git.apache.org>]

Github user BigCrunsh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2231#discussion_r17107948
  
    --- Diff: mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala ---
    @@ -125,4 +130,40 @@ class LogisticRegressionSuite extends FunSuite with LocalSparkContext with Shoul
         // Test prediction on Array.
         validatePrediction(validationData.map(row => model.predict(row.features)), validationData)
       }
    +
    +  test("logistic regression with initial weights and non-default regularizer") {
    --- End diff --
    
    yes, agree.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org