You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/05/26 09:46:36 UTC

Review Request 21904: CLOUDSTACK-6726: Fixing BVT test case test_network.py

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21904/
-----------------------------------------------------------

Review request for cloudstack and Santhosh Edukulla.


Bugs: CLOUDSTACK-6726
    https://issues.apache.org/jira/browse/CLOUDSTACK-6726


Repository: cloudstack-git


Description
-------

The list_nat_rules method called after deleting the NAT rule should be included within "assertRaises". We are looking for exception here.


Diffs
-----

  test/integration/smoke/test_network.py f81e95f 

Diff: https://reviews.apache.org/r/21904/diff/


Testing
-------

Yes. Tested on VMware.

Log:
Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 1470.458s

OK


Thanks,

Gaurav Aradhye


Re: Review Request 21904: CLOUDSTACK-6726: Fixing BVT test case test_network.py

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21904/#review43962
-----------------------------------------------------------


Commit 3125ae5c6a7a286a4891755e0d8d57bfc6e7ce97 in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3125ae5 ]

CLOUDSTACK-6726: Fixing BVT test case test_network.py


- ASF Subversion and Git Services


On May 26, 2014, 7:46 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21904/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 7:46 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6726
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6726
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The list_nat_rules method called after deleting the NAT rule should be included within "assertRaises". We are looking for exception here.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_network.py f81e95f 
> 
> Diff: https://reviews.apache.org/r/21904/diff/
> 
> 
> Testing
> -------
> 
> Yes. Tested on VMware.
> 
> Log:
> Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 1470.458s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 21904: CLOUDSTACK-6726: Fixing BVT test case test_network.py

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21904/#review43959
-----------------------------------------------------------


Commit 3e3dc7327179cf8b8a45a66e93c20ddcfa02b603 in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3e3dc73 ]

CLOUDSTACK-6726: Fixing BVT test case test_network.py


- ASF Subversion and Git Services


On May 26, 2014, 7:46 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21904/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 7:46 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6726
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6726
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The list_nat_rules method called after deleting the NAT rule should be included within "assertRaises". We are looking for exception here.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_network.py f81e95f 
> 
> Diff: https://reviews.apache.org/r/21904/diff/
> 
> 
> Testing
> -------
> 
> Yes. Tested on VMware.
> 
> Log:
> Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 1470.458s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 21904: CLOUDSTACK-6726: Fixing BVT test case test_network.py

Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21904/#review43924
-----------------------------------------------------------


4.4-forward:

author	Gaurav Aradhye <ga...@clogeny.com>	
	Mon, 26 May 2014 09:22:40 +0000 (14:22 +0530)
committer	Girish Shilamkar <gi...@clogeny.com>	
	Mon, 26 May 2014 09:22:40 +0000 (14:22 +0530)
commit	2cf16e5147d654216b0948950cd7fca058a5a1f2
tree	3a62ab276e66c5c96e3135cc050dbe97c2d3ecf9
parent	c3c809647667229c4e46096a85dbbf75eec4d005

- Gaurav Aradhye


On May 26, 2014, 1:16 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21904/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 1:16 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6726
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6726
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The list_nat_rules method called after deleting the NAT rule should be included within "assertRaises". We are looking for exception here.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_network.py f81e95f 
> 
> Diff: https://reviews.apache.org/r/21904/diff/
> 
> 
> Testing
> -------
> 
> Yes. Tested on VMware.
> 
> Log:
> Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 1470.458s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 21904: CLOUDSTACK-6726: Fixing BVT test case test_network.py

Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21904/#review43923
-----------------------------------------------------------


4.4-forward:

author	Gaurav Aradhye <ga...@clogeny.com>	
	Mon, 26 May 2014 09:22:40 +0000 (14:22 +0530)
committer	Girish Shilamkar <gi...@clogeny.com>	
	Mon, 26 May 2014 09:22:40 +0000 (14:22 +0530)
commit	2cf16e5147d654216b0948950cd7fca058a5a1f2
tree	3a62ab276e66c5c96e3135cc050dbe97c2d3ecf9
parent	c3c809647667229c4e46096a85dbbf75eec4d005

- Gaurav Aradhye


On May 26, 2014, 1:16 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21904/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 1:16 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6726
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6726
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The list_nat_rules method called after deleting the NAT rule should be included within "assertRaises". We are looking for exception here.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_network.py f81e95f 
> 
> Diff: https://reviews.apache.org/r/21904/diff/
> 
> 
> Testing
> -------
> 
> Yes. Tested on VMware.
> 
> Log:
> Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 1470.458s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 21904: CLOUDSTACK-6726: Fixing BVT test case test_network.py

Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21904/#review43953
-----------------------------------------------------------

Ship it!


Ship It!

- Santhosh Edukulla


On May 26, 2014, 7:46 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21904/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 7:46 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6726
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6726
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The list_nat_rules method called after deleting the NAT rule should be included within "assertRaises". We are looking for exception here.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_network.py f81e95f 
> 
> Diff: https://reviews.apache.org/r/21904/diff/
> 
> 
> Testing
> -------
> 
> Yes. Tested on VMware.
> 
> Log:
> Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 1470.458s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 21904: CLOUDSTACK-6726: Fixing BVT test case test_network.py

Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21904/#review43952
-----------------------------------------------------------


Santhosh, can you please review this?

- Gaurav Aradhye


On May 26, 2014, 1:16 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21904/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 1:16 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6726
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6726
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The list_nat_rules method called after deleting the NAT rule should be included within "assertRaises". We are looking for exception here.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_network.py f81e95f 
> 
> Diff: https://reviews.apache.org/r/21904/diff/
> 
> 
> Testing
> -------
> 
> Yes. Tested on VMware.
> 
> Log:
> Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 1470.458s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>