[jira] [Commented] (KAFKA-5525) Streams reset tool should have same console output with or without dry-run

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064783#comment-16064783 ] 

ASF GitHub Bot commented on KAFKA-5525:
---------------------------------------

GitHub user ppatierno opened a pull request:

    https://github.com/apache/kafka/pull/3443

    KAFKA-5525: Streams reset tool should have same console output with or without dry-run

    Fixed console output to be consistent with/without dry-run option

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ppatierno/kafka kafka-5525

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3443.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3443
    
----
commit 0cc0161d2907ebc802364b5ff7eb7b99fed7afbc
Author: ppatierno <pp...@live.com>
Date:   2017-06-27T12:52:57Z

    Fixed console output to be consistent with/without dry-run option

----


> Streams reset tool should have same console output with or without dry-run
> --------------------------------------------------------------------------
>
>                 Key: KAFKA-5525
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5525
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Paolo Patierno
>            Assignee: Paolo Patierno
>            Priority: Minor
>
> Hi,
> I see that the Streams reset tool provides a console output a little bit different when you execute it using "dry-run" (so without executing any real action) or without it.
> With dry-run :
> {code}
> ----Dry run displays the actions which will be performed when running Streams Reset Tool----
> Following input topics offsets will be reset to beginning (for consumer group streams-wordcount)
> Topic: streams-file-input
> Done.
> Deleting all internal/auto-created topics for application streams-wordcount
> Topic: streams-wordcount-Counts-repartition
> Topic: streams-wordcount-Counts-changelog
> Done.
> {code}
> without dry-run :
> {code}
> Seek-to-beginning for input topics [streams-file-input]
> Done.
> Deleting all internal/auto-created topics for application streams-wordcount
> Topic streams-wordcount-Counts-repartition is marked for deletion.
> Note: This will have no impact if delete.topic.enable is not set to true.
> Topic streams-wordcount-Counts-changelog is marked for deletion.
> Note: This will have no impact if delete.topic.enable is not set to true.
> Done.
> {code}
> I think that the version with dry-run related to show "Seek-to-beginning for input topics [streams-file-input]" could be used even for version without dry-run.
> The output should be consistent and the only difference should be on executing real actions or not.
> I'm working on a trivial PR for a proposal.
> Thanks,
> Paolo



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)