You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/12/01 08:19:58 UTC
[GitHub] [bookkeeper] lordcheng10 opened a new pull request, #3681: [improve][server] When dbStorage_directIOEntryLogger=true, the entryLogPerLedger is not supported
lordcheng10 opened a new pull request, #3681:
URL: https://github.com/apache/bookkeeper/pull/3681
### Motivation
When dbStorage_directIOEntryLogger=true, add support for entryLogPerLedger.
### Changes
1. Add a new DirectEntryLoggerForEntryLogPerLedger class extended from DirectEntryLogger;
2. In DbLedgerStorage, when building the EntryLogger object, judge whether entryLogPerLedgerEnabled is enabled:
```
if (conf.isEntryLogPerLedgerEnabled()) {
entrylogger = new DirectEntryLoggerForEntryLogPerLedger(conf, ledgerDir,
new EntryLogIdsImpl(ledgerDirsManager, slog),
new NativeIOImpl(),
allocator, entryLoggerWriteExecutor, entryLoggerFlushExecutor,
conf.getEntryLogSizeLimit(),
conf.getNettyMaxFrameSizeBytes() - 500,
perDirectoryTotalWriteBufferSize,
perDirectoryTotalReadBufferSize,
readBufferSize,
numReadThreads,
maxFdCacheTimeSeconds,
slog, statsLogger);
} else {
entrylogger = new DirectEntryLogger(ledgerDir, new EntryLogIdsImpl(ledgerDirsManager, slog),
new NativeIOImpl(),
allocator, entryLoggerWriteExecutor, entryLoggerFlushExecutor,
conf.getEntryLogSizeLimit(),
conf.getNettyMaxFrameSizeBytes() - 500,
perDirectoryTotalWriteBufferSize,
perDirectoryTotalReadBufferSize,
readBufferSize,
numReadThreads,
maxFdCacheTimeSeconds,
slog, statsLogger);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3681: [improve][server] Support entryLogPerLedger, when dbStorage_directIOEntryLogger=true
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3681:
URL: https://github.com/apache/bookkeeper/pull/3681#issuecomment-1345537483
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3681: [improve][server] Support entryLogPerLedger, when dbStorage_directIOEntryLogger=true
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3681:
URL: https://github.com/apache/bookkeeper/pull/3681#issuecomment-1378181402
> ping @hangc0276
@lordcheng10 I'm reviewing this Pr, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3681: [improve][server] Support entryLogPerLedger, when dbStorage_directIOEntryLogger=true
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3681:
URL: https://github.com/apache/bookkeeper/pull/3681#issuecomment-1362570305
@hangc0276 @StevenLuMT @eolivelli PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3681: [improve][server] Support entryLogPerLedger, when dbStorage_directIOEntryLogger=true
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3681:
URL: https://github.com/apache/bookkeeper/pull/3681#issuecomment-1334678316
@eolivelli @hangc0276 @StevenLuMT PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3681: [improve][server] Support entryLogPerLedger, when dbStorage_directIOEntryLogger=true
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3681:
URL: https://github.com/apache/bookkeeper/pull/3681#issuecomment-1333680620
@hangc0276 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3681: [improve][server] Support entryLogPerLedger, when dbStorage_directIOEntryLogger=true
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3681:
URL: https://github.com/apache/bookkeeper/pull/3681#issuecomment-1345544099
> Would you please add a test to cover it?
Fixed,PTAL,thanks! @hangc0276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3681: [improve][server] Support entryLogPerLedger, when dbStorage_directIOEntryLogger=true
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3681:
URL: https://github.com/apache/bookkeeper/pull/3681#issuecomment-1350325934
PTAL,thanks! @hangc0276 @eolivelli @StevenLuMT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3681: [improve][server] Support entryLogPerLedger, when dbStorage_directIOEntryLogger=true
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3681:
URL: https://github.com/apache/bookkeeper/pull/3681#issuecomment-1371658591
@hangc0276 @StevenLuMT @eolivelli PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3681: [improve][server] Support entryLogPerLedger, when dbStorage_directIOEntryLogger=true
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3681:
URL: https://github.com/apache/bookkeeper/pull/3681#issuecomment-1348682392
> Would you please add a test to cover it?
Fixed,PTAL,thanks! @hangc0276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3681: [improve][server] Support entryLogPerLedger, when dbStorage_directIOEntryLogger=true
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3681:
URL: https://github.com/apache/bookkeeper/pull/3681#issuecomment-1378158005
ping @hangc0276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3681: [improve][server] Support entryLogPerLedger, when dbStorage_directIOEntryLogger=true
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3681:
URL: https://github.com/apache/bookkeeper/pull/3681#issuecomment-1336711262
> Would you please add a test to cover it?
OK, I will fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3681: [improve][server] Support entryLogPerLedger, when dbStorage_directIOEntryLogger=true
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3681:
URL: https://github.com/apache/bookkeeper/pull/3681#issuecomment-1378185722
> > ping @hangc0276
>
> @lordcheng10 I'm reviewing this Pr, thanks.
OKļ¼thank you !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3681: [improve][server] Support entryLogPerLedger, when dbStorage_directIOEntryLogger=true
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3681:
URL: https://github.com/apache/bookkeeper/pull/3681#issuecomment-1355948993
Ping @hangc0276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org