You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/10/29 04:25:22 UTC

[GitHub] [fineract] ptuomola commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

ptuomola commented on pull request #1251:
URL: https://github.com/apache/fineract/pull/1251#issuecomment-718351121


   @vorburger based on the above discussions, my suggestion would still be to change the validation to isOneOfEnumValues() and the conversion to be done with LoanStatus.valueOf(statusString.toUpperCase()) as you suggest. That would avoid a lot of "boilerplate" code. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org