[GitHub] [netbeans] sdedic commented on pull request #6228: Revert "Use resolve() method that actually throws exception."

["sdedic (via GitHub)" <gi...@apache.org>]

sdedic commented on PR #6228:
URL: https://github.com/apache/netbeans/pull/6228#issuecomment-1642366550

   I don't think that just throwing out a change is a good idea; without the change, the `resolve` method actually does not report ArtifactNotFound resolution failures (it returns artifacts that have isResolved() == false) and does not respect well recorded artifact origin (which was the reason for changing the implementation). In addition, the reason of inability to resolve the artiact (isResolved() == false) is discarded during the course.
   
   I an on vacation, and not really able to make a change until Sun 23; an option would be to have two `resolve()` methods - one broken retaining the old behaviour, the other the corrected one


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists