You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "Will-Lo (via GitHub)" <gi...@apache.org> on 2023/02/24 20:50:40 UTC

[GitHub] [gobblin] Will-Lo commented on a diff in pull request #3649: [GOBBLIN-1790] Add and change appropriate job status fields for observability events

Will-Lo commented on code in PR #3649:
URL: https://github.com/apache/gobblin/pull/3649#discussion_r1117630112


##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/GaaSObservabilityEventProducer.java:
##########
@@ -105,19 +107,19 @@ private GaaSObservabilityEventExperimental createGaaSObservabilityEvent(final St
     builder.setTimestamp(System.currentTimeMillis())
         .setFlowName(jobState.getProp(TimingEvent.FlowEventConstants.FLOW_NAME_FIELD))
         .setFlowGroup(jobState.getProp(TimingEvent.FlowEventConstants.FLOW_GROUP_FIELD))
+        .setFlowGraphEdgeId(jobState.getProp(TimingEvent.FlowEventConstants.FLOW_EDGE_FIELD))
         .setFlowExecutionId(jobState.getPropAsLong(TimingEvent.FlowEventConstants.FLOW_EXECUTION_ID_FIELD))
         .setJobName(jobState.getProp(TimingEvent.FlowEventConstants.JOB_NAME_FIELD))
         .setExecutorUrl(jobState.getProp(TimingEvent.METADATA_MESSAGE))
+        .setExecutorId(jobState.getProp(TimingEvent.FlowEventConstants.SPEC_EXECUTOR_FIELD))
         .setJobStartTime(jobStartTime)
         .setJobEndTime(jobEndTime)
+        .setJobOrchestratedTime(jobOrchestratedTime)
         .setIssues(issueList)
         .setJobStatus(status)
-        // TODO: Populate the below fields in a separate PR
-        .setExecutionUserUrn(null)
-        .setExecutorId("")
-        .setLastFlowModificationTime(0)
-        .setFlowGraphEdgeId("")
-        .setJobOrchestratedTime(null); // TODO: Investigate why TimingEvent.JOB_ORCHESTRATED_TIME is never propagated to the JobStatus
+        .setExecutionUserUrn(userToProxy)
+        // TODO: Set this value when flowSpec stores its modification time
+        .setLastFlowModificationTime(0);

Review Comment:
   I sort of can in a very roundabout way, I'd send it as part of job properties and bubble it up. I'll wait for your PR to go in first though



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org