[jira] [Commented] (NUTCH-1625) IndexerMapReduce skips FETCH_NOTMODIFIED

["Sebastian Nagel (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600334#comment-14600334 ] 

Sebastian Nagel commented on NUTCH-1625:
----------------------------------------

Is this really only legacy code and what's the exact problem? If a segment contains a document with a fetch datum of status FETCH_NOTMODIFIED
- the document should be already indexed from a prior segment where it has been really fetched
- there is definitely no content for this document in this segment because the server has responded with 304. Because documents with empty content are already skipped before a test for FETCH_NOTMODIFIED has no effect at all, afaics. Because the check for with DB_NOTMODIFIED (if property indexer.skip.notmodified == false) also comes after, it only affects docs which are fetched (FETCH_SUCCESS) and then recognized as not modified by signature comparison.

> IndexerMapReduce skips FETCH_NOTMODIFIED
> ----------------------------------------
>
>                 Key: NUTCH-1625
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1625
>             Project: Nutch
>          Issue Type: Bug
>          Components: indexer
>    Affects Versions: 1.7
>            Reporter: Markus Jelsma
>            Assignee: Markus Jelsma
>            Priority: Critical
>             Fix For: 1.11
>
>         Attachments: NUTCH-1625.patch, NUTCH-1625.patch
>
>
> IndexerMapReduce has the option to skip DB_NOTMODIFIED but legacy code also skips FETCH_NOTMODIFIED and the latter is not optional. We can keep the check but that should also include FETCH_NOTMODIFIED. Relying on FETCH_NOTMODIFIED isn't very useful anyway because since 1.5 orso we can safely rely on DB_NOTMODIFIED as it is properly set in the CrawlDBReducer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)