You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "o-nikolas (via GitHub)" <gi...@apache.org> on 2025/03/05 22:06:12 UTC
[PR] Remove remaining pieces of k8s exec specific UI pages [airflow]
o-nikolas opened a new pull request, #47422:
URL: https://github.com/apache/airflow/pull/47422
See this conversation for more context: https://github.com/apache/airflow/pull/47322#discussion_r1978488825
tl;dr: We have had one remaining executor coupling (re AIP-51, see 6a [here](https://github.com/apache/airflow/issues/27933)) with the k8s executor having a UI page which renders the kube config. This coupling has stayed unfixed because we have had two options:
1) Create a mechanism for all executors to vend UI pages. This has remained undone because we only have one example of this requirement so it doesn't seem to warrant the complexity and time it would take to build such a mechanism. Also, the state of UI in Airflow has been under flux in recent times.
2) Drop support for the k8s use case, which would remove the requirement of building 1). But this is a breaking change and we have not found a right time to do it, until now :)
As far as I can tell this page has actually already been removed in the recent PR to deprecate the old UI in Airflow, and the kube config endpoint as not as yet been re-created in the new UI. So this PR simply removes some of the remaining bits and pieces that used to trigger that endpoint to be present.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove remaining pieces of k8s exec specific UI pages [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #47422:
URL: https://github.com/apache/airflow/pull/47422#issuecomment-2704648358
Yep. looks good @o-nikolas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove remaining pieces of k8s exec specific UI pages [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #47422:
URL: https://github.com/apache/airflow/pull/47422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove remaining pieces of k8s exec specific UI pages [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on PR #47422:
URL: https://github.com/apache/airflow/pull/47422#issuecomment-2704649832
> Yep. looks good @o-nikolas
Unfortunately one conflict has popped up :sob: I'll resolve that and merge once the build is green again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove remaining pieces of k8s exec specific UI pages [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on PR #47422:
URL: https://github.com/apache/airflow/pull/47422#issuecomment-2704669688
> Moving fast. breaking things
Haha yeah, it was one of my other PRs that caused the conflict so I can't complain to much :laughing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove remaining pieces of k8s exec specific UI pages [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #47422:
URL: https://github.com/apache/airflow/pull/47422#issuecomment-2704667346
I may miss context. the intention is to remove the K8S spec tab from the UI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove remaining pieces of k8s exec specific UI pages [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #47422:
URL: https://github.com/apache/airflow/pull/47422#issuecomment-2704661522
Moving fast. breaking things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove remaining pieces of k8s exec specific UI pages [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on PR #47422:
URL: https://github.com/apache/airflow/pull/47422#issuecomment-2707063759
Any further thoughts you want to add before we merge @eladkal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove remaining pieces of k8s exec specific UI pages [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #47422:
URL: https://github.com/apache/airflow/pull/47422#issuecomment-2704661056
Damn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove remaining pieces of k8s exec specific UI pages [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on PR #47422:
URL: https://github.com/apache/airflow/pull/47422#issuecomment-2704676569
> I may miss context. the intention is to remove the K8S spec tab from the UI?
The PR description has all the details/history, but the tl;dr is yes. The `/rendered-k8s` endpoint is actually already removed. This PR just removes some of the remaining config bits left behind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org