You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/04/01 00:00:11 UTC
Re: Review Request 56367: Windows: Stout: Adapted `os::killtree` to
terminate job objects.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56367/
-----------------------------------------------------------
(Updated April 1, 2017, midnight)
Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park.
Summary (updated)
-----------------
Windows: Stout: Adapted `os::killtree` to terminate job objects.
Bugs: MESOS-6868
https://issues.apache.org/jira/browse/MESOS-6868
Repository: mesos
Description (updated)
-------
On Windows, a "process tree" is in fact a job object. Thus, the
implementation of `os::killtree` on Windows is an adapter which terminates
the job object corresponding to the process group represented by the
given PID.
Diffs
-----
3rdparty/stout/include/stout/os/windows/killtree.hpp 15b2faa7b52feeb067004e9b556f06d1acfb9763
Diff: https://reviews.apache.org/r/56367/diff/3/
Testing
-------
Testing done at end of chain.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 56367: Windows: Stout: Adapted `os::killtree` to
terminate job objects.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On April 3, 2017, 10:20 p.m., Joseph Wu wrote:
> > 3rdparty/stout/include/stout/os/windows/killtree.hpp
> > Lines 54 (patched)
> > <https://reviews.apache.org/r/56367/diff/4/?file=1682899#file1682899line56>
> >
> > s/it/return type/
Thanks!
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56367/#review170915
-----------------------------------------------------------
On April 1, 2017, 4:38 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56367/
> -----------------------------------------------------------
>
> (Updated April 1, 2017, 4:38 a.m.)
>
>
> Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park.
>
>
> Bugs: MESOS-6868
> https://issues.apache.org/jira/browse/MESOS-6868
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On Windows, a "process tree" is in fact a job object. Thus, the
> implementation of `os::killtree` on Windows is an adapter which terminates
> the job object corresponding to the process group represented by the
> given PID.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/killtree.hpp 15b2faa7b52feeb067004e9b556f06d1acfb9763
>
>
> Diff: https://reviews.apache.org/r/56367/diff/4/
>
>
> Testing
> -------
>
> Testing done at end of chain.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 56367: Windows: Stout: Adapted `os::killtree` to
terminate job objects.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56367/#review170915
-----------------------------------------------------------
Ship it!
LGTM. I can fix the below before committing.
3rdparty/stout/include/stout/os/windows/killtree.hpp
Lines 54 (patched)
<https://reviews.apache.org/r/56367/#comment243765>
s/it/return type/
- Joseph Wu
On March 31, 2017, 9:38 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56367/
> -----------------------------------------------------------
>
> (Updated March 31, 2017, 9:38 p.m.)
>
>
> Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park.
>
>
> Bugs: MESOS-6868
> https://issues.apache.org/jira/browse/MESOS-6868
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On Windows, a "process tree" is in fact a job object. Thus, the
> implementation of `os::killtree` on Windows is an adapter which terminates
> the job object corresponding to the process group represented by the
> given PID.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/killtree.hpp 15b2faa7b52feeb067004e9b556f06d1acfb9763
>
>
> Diff: https://reviews.apache.org/r/56367/diff/4/
>
>
> Testing
> -------
>
> Testing done at end of chain.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 56367: Windows: Stout: Adapted `os::killtree` to
terminate job objects.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56367/
-----------------------------------------------------------
(Updated April 1, 2017, 4:38 a.m.)
Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park.
Changes
-------
Removed "shim", a derogatory term. (Original comment was redundant too).
Bugs: MESOS-6868
https://issues.apache.org/jira/browse/MESOS-6868
Repository: mesos
Description
-------
On Windows, a "process tree" is in fact a job object. Thus, the
implementation of `os::killtree` on Windows is an adapter which terminates
the job object corresponding to the process group represented by the
given PID.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/windows/killtree.hpp 15b2faa7b52feeb067004e9b556f06d1acfb9763
Diff: https://reviews.apache.org/r/56367/diff/4/
Changes: https://reviews.apache.org/r/56367/diff/3-4/
Testing
-------
Testing done at end of chain.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 56367: Windows: Stout: Adapted `os::killtree` to
terminate job objects.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56367/#review170803
-----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/killtree.hpp
Line 35 (original), 37 (patched)
<https://reviews.apache.org/r/56367/#comment243681>
Replace shim with adapter.
- Andrew Schwartzmeyer
On April 1, 2017, midnight, Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56367/
> -----------------------------------------------------------
>
> (Updated April 1, 2017, midnight)
>
>
> Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park.
>
>
> Bugs: MESOS-6868
> https://issues.apache.org/jira/browse/MESOS-6868
>
>
> Repository: mesos
>
>
> Description
> -------
>
> On Windows, a "process tree" is in fact a job object. Thus, the
> implementation of `os::killtree` on Windows is an adapter which terminates
> the job object corresponding to the process group represented by the
> given PID.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/killtree.hpp 15b2faa7b52feeb067004e9b556f06d1acfb9763
>
>
> Diff: https://reviews.apache.org/r/56367/diff/3/
>
>
> Testing
> -------
>
> Testing done at end of chain.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>