[GitHub] [doris] wsjz commented on a diff in pull request #19012: [refactor](fs)(step2)separate the storage and filesystem methods

["wsjz (via GitHub)" <gi...@apache.org>]

wsjz commented on code in PR #19012:
URL: https://github.com/apache/doris/pull/19012#discussion_r1176189232


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/S3Resource.java:
##########
@@ -128,17 +128,17 @@ private static boolean pingS3(CloudCredentialWithEndpoint credential, String buc
         propertiesPing.put(S3Properties.Env.REGION, credential.getRegion());
         propertiesPing.put(PropertyConverter.USE_PATH_STYLE, "false");
         properties.putAll(propertiesPing);
-        S3Storage storage = new S3Storage(properties);
+        S3FileSystem fileSystem = new S3FileSystem(properties);

Review Comment:
   Test is pass



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org