[I] [Studio][Bug] Reject unsupported topology node types atomically [rocketmq-dashboard]

["yyqdbngt (via GitHub)" <gi...@apache.org>]

yyqdbngt opened a new issue, #2216:
URL: https://github.com/apache/rocketmq-dashboard/issues/2216

   ## Problem
   
   `ClusterTopology.addNode` inserts a node into `nodeMap` before checking its type. Unknown types therefore create ghost map entries that are absent from every typed node list. A null type also mutates the map before the subsequent switch throws.
   
   This leaves `nodeMap`, the typed lists, and `getTotalNodeCount()` inconsistent after a rejected input.
   
   ## Expected behavior
   
   `addNode` should reject null and unsupported node types before changing any topology state. The three supported types (`NAMESRV`, `BROKER`, and `PROXY`) should keep their existing routing behavior.
   
   ## Proposed approach
   
   Validate the node type at the method boundary, then construct and insert the node only after validation succeeds. Add focused tests for all supported types and for atomic rejection of null/unknown values.
   
   I searched issues and pull requests across all states for `ClusterTopology.addNode`, unsupported node types, and ghost topology nodes. I did not find an existing implementation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Studio][Bug] Reject unsupported topology node types atomically [rocketmq-dashboard]

["yyqdbngt (via GitHub)" <gi...@apache.org>]

yyqdbngt commented on issue #2216:
URL: https://github.com/apache/rocketmq-dashboard/issues/2216#issuecomment-5300374551

   Withdrawn: this issue was created under the wrong contributor account because of a local credential-routing error. No implementation or pull request will reference it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Withdrawn: account routing error] Reject unsupported topology node types atomically [rocketmq-dashboard]

["yyqdbngt (via GitHub)" <gi...@apache.org>]

yyqdbngt closed issue #2216: [Withdrawn: account routing error] Reject unsupported topology node types atomically
URL: https://github.com/apache/rocketmq-dashboard/issues/2216


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org