[GitHub] [daffodil-vscode] Shanedell commented on a change in pull request #71: Fix Launch Wizard for Windows

[GitBox <gi...@apache.org>]

Shanedell commented on a change in pull request #71:
URL: https://github.com/apache/daffodil-vscode/pull/71#discussion_r782546700



##########
File path: src/launchWizard/launchWizard.ts
##########
@@ -52,12 +53,15 @@ async function createUpdateConfigFile(data, updateOrCreate) {
     fs.mkdirSync(`${rootPath}/.vscode`)
   }
 
+  const launchPath =
+    os.platform() === 'win32'

Review comment:
       So from my testing on a Windows VM, I believe we don't need the osPath. I believe the open text document file function may be converting paths under the hood as I had never had issues with the class paths until trying to load the style and script files for the launch wizard. Everything else worked fine I assume because it may be handled by a lot of the VSCode API functions by default




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org