[GitHub] [accumulo] ctubbsii commented on a diff in pull request #2987: Fixes for new Admin fate command

[GitBox <gi...@apache.org>]

ctubbsii commented on code in PR #2987:
URL: https://github.com/apache/accumulo/pull/2987#discussion_r984801601


##########
server/base/src/main/java/org/apache/accumulo/server/util/Admin.java:
##########
@@ -250,7 +251,7 @@ static class FateOpsCommand {
     boolean printJson;
 
     @Parameter(names = {"-s", "--state"},
-        description = "<state>[ -s <state>...] Print transactions in the state(s) {NEW, IN_PROGRESS, FAILED_IN_PROGRESS, FAILED, SUCCESSFUL}")
+        description = "<state>... Print transactions in the state(s) {NEW, IN_PROGRESS, FAILED_IN_PROGRESS, FAILED, SUCCESSFUL}")

Review Comment:
   I still don't think we need this filtering. Users can filter by piping the output to grep, or whatever they like. We can put the list of states elsewhere in the help/description. The output should be easily computer-readable, to make parsing the output easy... but otherwise, we don't need to bake in too many filtering/display options. Let's keep it simple.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org