[jira] [Commented] (OOZIE-3234) Revise TestAuthorizationService

["Andras Piros (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465730#comment-16465730 ] 

Andras Piros commented on OOZIE-3234:
-------------------------------------

I like the idea [~orova]!

> Revise TestAuthorizationService
> -------------------------------
>
>                 Key: OOZIE-3234
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3234
>             Project: Oozie
>          Issue Type: Improvement
>          Components: tests
>    Affects Versions: 5.0.0
>            Reporter: Peter Orova
>            Assignee: Peter Orova
>            Priority: Minor
>
> The {{TestAuthorizationService}}'s maintainability is low due to
>  * the many magic boolean variables
>  * the init methods having 3+ parameters
> One way this could be addressed is to introduce a simplified version of Builder pattern via a private nested class, to replace the functionality of the {{init}} methods.
> This approach would allow for a much more readable, flexible and maintainable code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)