You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/30 13:41:53 UTC

[GitHub] [flink] rkhachatryan commented on a change in pull request #11948: [FLINK-17467] Align channels on savepoint in UC mode

rkhachatryan commented on a change in pull request #11948:
URL: https://github.com/apache/flink/pull/11948#discussion_r418018426



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -560,8 +559,8 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
 			}
 
 			final boolean wasEmpty;
-			final CheckpointBarrier notifyReceivedBarrier;
-			final Buffer notifyReceivedBuffer;
+			final Optional<CheckpointBarrier> notifyReceivedBarrier;
+			final Optional<Buffer> notifyReceivedBuffer;

Review comment:
       Yes, only for symmetry.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org