You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "weimingdiit (via GitHub)" <gi...@apache.org> on 2024/10/21 06:19:29 UTC
[PR] HDDS-11599. Add time zone information in ReportSubcommand#outputHeader [ozone]
weimingdiit opened a new pull request, #7338:
URL: https://github.com/apache/ozone/pull/7338
## What changes were proposed in this pull request?
Add time zone information in ReportSubcommand#outputHeader
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11599
## How was this patch tested?
manual tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11599. Add time zone information in ReportSubcommand#outputHeader [ozone]
Posted by "weimingdiit (via GitHub)" <gi...@apache.org>.
weimingdiit commented on PR #7338:
URL: https://github.com/apache/ozone/pull/7338#issuecomment-2439441628
> Hi @weimingdiit. Could you share the output after this change?
Sure,my current time with time zone is 2024-10-26T15:09:49
Before modification:
> Container Summary Report generated at 2024-10-26T07:09:49Z
>
> ==========================================================
After modification:
> Container Summary Report generated at 2024-10-26T15:09:49
>
> ==========================================================
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11599. Add time zone information in ReportSubcommand#outputHeader [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7338:
URL: https://github.com/apache/ozone/pull/7338#issuecomment-2440989220
> Sure,my current time with time zone is 2024-10-26T15:09:49
>
> Before modification:
>
> > Container Summary Report generated at 2024-10-26T07:09:49Z
> > ==========================================================
>
> After modification:
>
> > Container Summary Report generated at 2024-10-26T15:09:49
> > ==========================================================
It seems to me the change actually removes timezone information from the output. `07:09:49Z` may be inconvenient, but it's clear that time is UTC. `15:09:49` could be different time in various timezones.
So we may need to consider including timezone in the output.
Also:
Is output of other Ozone commands consistent in how they display time? (date/time format, display timezone (UTC vs. local))
- If so, is this change making it consistent with other commands?
- If not:
- What kind of different output formats do we have?
- Is this the only command that needs to be changed?
- Is the new format (local time + time zone) the desired output format we should standardise on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11599. Add time zone information in ReportSubcommand#outputHeader [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7338:
URL: https://github.com/apache/ozone/pull/7338#issuecomment-2457916345
@weimingdiit `ContainerBalancerStatusSubcommand` may be the outlier in this case, and I'm not sure we should follow the same pattern. The only other usage of `LocalDateTime` is in code related to certificates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11599. Add time zone information in ReportSubcommand#outputHeader [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #7338: HDDS-11599. Add time zone information in ReportSubcommand#outputHeader
URL: https://github.com/apache/ozone/pull/7338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11599. Add time zone information in ReportSubcommand#outputHeader [ozone]
Posted by "weimingdiit (via GitHub)" <gi...@apache.org>.
weimingdiit commented on PR #7338:
URL: https://github.com/apache/ozone/pull/7338#issuecomment-2443870795
> Is output of other Ozone commands consistent in how they display time? (date/time format, display timezone (UTC vs. local))
>
> * If so, is this change making it consistent with other commands?
Yes, I checked other ozone commands, and my output is consistent with the format in the ContainerBalancerStatusSubcommand command.
The code in ContainerBalancerStatusSubcommand is as follows，the local date and time without the time zone is output in ContainerBalancerStatusSubcommand
`if (isRunning) {
LocalDateTime dateTime =
LocalDateTime.ofInstant(Instant.ofEpochSecond(balancerStatusInfo.getStartedAt()), ZoneId.systemDefault());
System.out.println("ContainerBalancer is Running.");
if (verbose) {
System.out.printf("Started at: %s %s%n%n", dateTime.toLocalDate(), dateTime.toLocalTime());
System.out.println(getConfigurationPrettyString(balancerStatusInfo.getConfiguration()));
......
}
}
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11599. Add time zone information in ReportSubcommand#outputHeader [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7338:
URL: https://github.com/apache/ozone/pull/7338#issuecomment-2532681086
/pending discussion on dev mailing list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11599. Add time zone information in ReportSubcommand#outputHeader [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7338:
URL: https://github.com/apache/ozone/pull/7338#issuecomment-2566768790
Thank you very much for the patch. I am closing this PR __temporarily__ as there was no activity recently and it is waiting for response from its author.
It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.
It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.
If you need ANY help to finish this PR, please [contact the community](https://github.com/apache/hadoop-ozone#contact) on the mailing list or the slack channel."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org