You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "neilcsmith-net (via GitHub)" <gi...@apache.org> on 2023/04/21 14:09:49 UTC
[GitHub] [netbeans] neilcsmith-net opened a new pull request, #5867: Make Options category buttons accent colour aware in FlatLaf.
neilcsmith-net opened a new pull request, #5867:
URL: https://github.com/apache/netbeans/pull/5867
Fixes the option category buttons to respond to accent colour with FlatLaf Light. Also fixes the issue with illegible foreground text mentioned in #5798
This does change the default blue to be much darker than the existing hardcoded colour though.
This also does subtly change the behaviour on other LaFs in that `Tree.selectionForeground` is used in cases where `Tree.selectionBackground` might be - that seems to be the safer approach anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #5867: Make Options category buttons accent colour aware in FlatLaf.
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #5867:
URL: https://github.com/apache/netbeans/pull/5867#issuecomment-1518914962
Thanks for the fix, looks good as long as it's tested!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #5867: Make Options category buttons accent colour aware in FlatLaf.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net merged PR #5867:
URL: https://github.com/apache/netbeans/pull/5867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5867: Make Options category buttons accent colour aware in FlatLaf.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5867:
URL: https://github.com/apache/netbeans/pull/5867#issuecomment-1518136164
> thank you for fixing this - I can't explain how I overlooked that (likely because i started to color code dev builds at some point in time to not confuse them with each other).
Thanks. No problem. I was doing that until recently too - switched to changing my main install colours instead, as I was getting confused every time I did a clean build! :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5867: Make Options category buttons accent colour aware in FlatLaf.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5867:
URL: https://github.com/apache/netbeans/pull/5867#issuecomment-1520434334
> > This does change the default blue to be much darker than the existing hardcoded colour though.
>
> But only for FlatLaf Light. Other L&Fs (FlatLaf Dark, Windows, Nimbus, etc) are not changed.
>
> To keep the light blue selection color, you could add following to `FlatLightLaf.properties`:
>
> ```ini
> nb.options.categories.selectionBackground = tint(@selectionBackground,70%)
> nb.options.categories.selectionForeground = @foreground
> ```
Thanks for the review! Yes, should have made it clear that that only affects the default L&F (ie. FlatLaf Light). The point underneath it about `Tree,selectionForeground` is the only bit that could affect other L&Fs.
I did consider doing what you suggested, but thought there was some benefit to keeping the light and dark settings consistent and in one place (given the other issue that triggered this!). I'll merge as is for now, but have no strong preference either way if you want to add those overrides into the light theme.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists