You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Mariia Mykhailova (JIRA)" <ji...@apache.org> on 2015/11/05 01:56:27 UTC

[jira] [Commented] (REEF-900) Fix trivial issues in Java code detected by PMD

    [ https://issues.apache.org/jira/browse/REEF-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990849#comment-14990849 ] 

Mariia Mykhailova commented on REEF-900:
----------------------------------------

PR https://github.com/apache/incubator-reef/pull/612

> Fix trivial issues in Java code detected by PMD
> -----------------------------------------------
>
>                 Key: REEF-900
>                 URL: https://issues.apache.org/jira/browse/REEF-900
>             Project: REEF
>          Issue Type: Sub-task
>          Components: All
>            Reporter: Mariia Mykhailova
>            Assignee: Mariia Mykhailova
>            Priority: Trivial
>
> Several issues detected by PMD are trivial and don't cause behavior or interface changes when fixed. The approximate list is:
> * Nested if statements could be combined
> * Avoid duplicate imports 
> * Useless parentheses (duplicated by Checkstyle UnnecessaryParentheses, the most frequent cause in our code are assert statements)
> * Avoid modifiers which are implied by the context
> * Avoid unnecessary temporaries
> * Unnecessary use of fully qualified name
> * Avoid unused local variables
> These seem not worth creating one JIRA per issue type, so I bundled them here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)