You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/08/10 05:37:44 UTC
[GitHub] [drill] dzamo opened a new pull request #2096: Documentation updates for 1.18
dzamo opened a new pull request #2096:
URL: https://github.com/apache/drill/pull/2096
TODO: Either open a Jira ticket for this work and replace this description with the template below or avoid the Jira process for docs and delete the template below.
# [DRILL-XXXX](https://issues.apache.org/jira/browse/DRILL-XXXX): PR Title
(Please replace `PR Title` with actual PR Title)
## Description
(Please describe the change. If more than one ticket is fixed, include a reference to those tickets.)
## Documentation
(Please describe user-visible changes similar to what should appear in the Drill documentation.)
## Testing
(Please describe how this PR has been tested.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo edited a comment on pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
dzamo edited a comment on pull request #2096:
URL: https://github.com/apache/drill/pull/2096#issuecomment-713735671
@cgivre If this isn't holding anything back and we can wait a few more days then let us, because I certainly have more to add, including the requested changes. My apologies for the stalling. As COVID-19 lockdown lifted where I am, a period of intense travelling ensued. But it concluded at the start of this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo commented on pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
dzamo commented on pull request #2096:
URL: https://github.com/apache/drill/pull/2096#issuecomment-721120306
I think that may just be a wrap.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo edited a comment on pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
dzamo edited a comment on pull request #2096:
URL: https://github.com/apache/drill/pull/2096#issuecomment-721120306
@cgivre: I think that may just be a wrap.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2096:
URL: https://github.com/apache/drill/pull/2096#issuecomment-713759671
@dzamo
Thanks for getting back with me. Would a week or so be a reasonable timetable for next review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2096:
URL: https://github.com/apache/drill/pull/2096#issuecomment-691682583
@dzamo
Any update?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo commented on pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
dzamo commented on pull request #2096:
URL: https://github.com/apache/drill/pull/2096#issuecomment-713735671
If this isn't holding anything back and we can wait a few more days then let us, because I certainly have more to add. My apologies for the stalling. As COVID-19 lockdown lifted where I am, a period of intense travelling ensued. But it concluded at the start of this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2096:
URL: https://github.com/apache/drill/pull/2096#issuecomment-671406571
One more thing... take a look here https://github.com/apache/drill/tree/master/contrib/udfs for UDFs included with Drill. Ideally these should be in the docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo commented on a change in pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
dzamo commented on a change in pull request #2096:
URL: https://github.com/apache/drill/pull/2096#discussion_r514828617
##########
File path: _docs/connect-a-data-source/plugins/114-image-metadata-format-plugin.md
##########
@@ -1,6 +1,6 @@
---
title: "Image Metadata Format Plugin"
Review comment:
Absolutely. I've moved the format plugins away from the storage plugins, and under Data Sources and File Formats which seems to me to be the best available place. I think there are further other reorganisation opportunities like this, but they can be for future PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo edited a comment on pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
dzamo edited a comment on pull request #2096:
URL: https://github.com/apache/drill/pull/2096#issuecomment-713762757
@cgivre
Yes, that works for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo merged pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
dzamo merged pull request #2096:
URL: https://github.com/apache/drill/pull/2096
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo commented on pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
dzamo commented on pull request #2096:
URL: https://github.com/apache/drill/pull/2096#issuecomment-713762757
@cgivre
Yes works for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2096:
URL: https://github.com/apache/drill/pull/2096#issuecomment-671404618
Could you also please add the following docs to the section about querying files?
- https://github.com/apache/drill/tree/master/contrib/format-excel
- https://github.com/apache/drill/tree/master/contrib/format-hdf5
- https://github.com/apache/drill/tree/master/contrib/format-spss
- https://github.com/apache/drill/tree/master/contrib/format-syslog
- https://github.com/apache/drill/tree/master/contrib/format-esri
Also, we have a few new storage plugins which we should add to the docs which are:
- https://github.com/apache/drill/tree/master/contrib/storage-http
- https://github.com/apache/drill/tree/master/contrib/storage-druid
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo commented on pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
dzamo commented on pull request #2096:
URL: https://github.com/apache/drill/pull/2096#issuecomment-693347917
Hi Charles, I've been travelling. I hope to return to this next week.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo edited a comment on pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
dzamo edited a comment on pull request #2096:
URL: https://github.com/apache/drill/pull/2096#issuecomment-713735671
@cgivre If this isn't holding anything back and we can wait a few more days then let us, because I certainly have more to add. My apologies for the stalling. As COVID-19 lockdown lifted where I am, a period of intense travelling ensued. But it concluded at the start of this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo commented on a change in pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
dzamo commented on a change in pull request #2096:
URL: https://github.com/apache/drill/pull/2096#discussion_r514342214
##########
File path: _docs/configure-drill/configuration-options/030-planning-and-exececution-options.md
##########
@@ -27,11 +27,11 @@ You can run the following query to see a list of options:
The query returns a table that lists options with descriptions and other details. As of Drill 1.15, there are 179 options:
SELECT COUNT() AS num_of_sysopts FROM sys.options;
- +-----------------+
+ |-----------------|
| num_of_sysopts |
- +-----------------+
+ |-----------------|
| 179 |
- +-----------------+
+ |-----------------|
Review comment:
I couldn't see any _major_ problem here. I've corrected `###Drill-override...` to `### Drill-override...`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on a change in pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
cgivre commented on a change in pull request #2096:
URL: https://github.com/apache/drill/pull/2096#discussion_r467897882
##########
File path: _docs/configure-drill/configuration-options/030-planning-and-exececution-options.md
##########
@@ -27,11 +27,11 @@ You can run the following query to see a list of options:
The query returns a table that lists options with descriptions and other details. As of Drill 1.15, there are 179 options:
SELECT COUNT() AS num_of_sysopts FROM sys.options;
- +-----------------+
+ |-----------------|
| num_of_sysopts |
- +-----------------+
+ |-----------------|
| 179 |
- +-----------------+
+ |-----------------|
Review comment:
Nit: `###Drill-override.conf` Row Limit Settings is not formatted correctly.
##########
File path: _docs/connect-a-data-source/plugins/114-image-metadata-format-plugin.md
##########
@@ -1,6 +1,6 @@
---
title: "Image Metadata Format Plugin"
Review comment:
IMHO, We could use a little re-organization here. This particular page is about querying image metadata via Drill. We should collect any pages about formats under the section about querying the file system instead of treating this like it was a storage plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2096: Documentation updates for 1.18
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2096:
URL: https://github.com/apache/drill/pull/2096#issuecomment-713713764
Hi @dzamo
I hope all is well. Do you have any update on this? Should we just go ahead and commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org