You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/08/18 08:57:34 UTC
[GitHub] [incubator-kyuubi] wuqiao opened a new pull request, #3266: Update README.md
wuqiao opened a new pull request, #3266:
URL: https://github.com/apache/incubator-kyuubi/pull/3266
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3266: Update CONTRIBUTE.md
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3266:
URL: https://github.com/apache/incubator-kyuubi/pull/3266#issuecomment-1219275564
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #3266: Update CONTRIBUTE.md
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #3266: Update CONTRIBUTE.md
URL: https://github.com/apache/incubator-kyuubi/pull/3266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3266: Update README.md
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3266:
URL: https://github.com/apache/incubator-kyuubi/pull/3266#discussion_r948840499
##########
README.md:
##########
@@ -121,3 +121,6 @@ Its nine tails stand for end-to-end multi-tenancy support of this project.
## License
This project is licensed under the Apache 2.0 License. See the [LICENSE](./LICENSE) file for details.
+
+## Community
+ Join in our [Slack](https://join.slack.com/t/apachekyuubi/shared_invite/zt-1e1qw68g4-yE5HJsVVDin~ABtZISyuxg) Channel !
Review Comment:
nit: Add a new line between head and content , and remove the first space char
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] wuqiao commented on a diff in pull request #3266: Update CONTRIBUTE.md
Posted by GitBox <gi...@apache.org>.
wuqiao commented on code in PR #3266:
URL: https://github.com/apache/incubator-kyuubi/pull/3266#discussion_r948865645
##########
README.md:
##########
@@ -121,3 +121,6 @@ Its nine tails stand for end-to-end multi-tenancy support of this project.
## License
This project is licensed under the Apache 2.0 License. See the [LICENSE](./LICENSE) file for details.
+
+## Community
+ Join in our [Slack](https://join.slack.com/t/apachekyuubi/shared_invite/zt-1e1qw68g4-yE5HJsVVDin~ABtZISyuxg) Channel !
Review Comment:
This change has been removed and placed in the CONTRIBUTE file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org