You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 15:36:52 UTC

[GitHub] [beam] damccorm opened a new issue, #20154: Use cmp in fullvalue_test.go

damccorm opened a new issue, #20154:
URL: https://github.com/apache/beam/issues/20154

   We could probably update the comparison helpers in [fullvalue_test.go](https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/exec/fullvalue_test.go) to use cmp options and Transformers instead which would make things much clearer.
   
   Imported from Jira [BEAM-9753](https://issues.apache.org/jira/browse/BEAM-9753). Original Jira may contain additional context.
   Reported by: danoliveira.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] thinh2 commented on issue #20154: Use cmp in fullvalue_test.go

Posted by "thinh2 (via GitHub)" <gi...@apache.org>.

thinh2 commented on issue #20154:
URL: https://github.com/apache/beam/issues/20154#issuecomment-1679160504

   Hi, does this issue still open for contribution?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ZhengLin-Li commented on issue #20154: Use cmp in fullvalue_test.go

Posted by GitBox <gi...@apache.org>.

ZhengLin-Li commented on issue #20154:
URL: https://github.com/apache/beam/issues/20154#issuecomment-1362865081

   Hi, I am new to this project and willing to contribute.
   
   Could you tell me more about the details? For example, what are comparison helper, cmp options, and transformers?
   
   I looked up the original Jira but couldn't find any information about what they are. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on issue #20154: Use cmp in fullvalue_test.go

Posted by GitBox <gi...@apache.org>.

damccorm commented on issue #20154:
URL: https://github.com/apache/beam/issues/20154#issuecomment-1362884939

   The goal here would be to replace or refactor our helpers (for example https://github.com/apache/beam/blob/3b9ab77ef90519adda0255031ffc3ae598192edc/sdks/go/pkg/beam/core/runtime/exec/fullvalue_test.go#L155) to use the [cmp](https://pkg.go.dev/github.com/google/go-cmp/cmp) package rather than traversing the whole object and doing reflection equality checks to compare them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org