You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by "Jake Maes (JIRA)" <ji...@apache.org> on 2017/04/01 00:39:41 UTC

[jira] [Updated] (SAMZA-1184) Improvements to Merge Script

     [ https://issues.apache.org/jira/browse/SAMZA-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jake Maes updated SAMZA-1184:
-----------------------------
    Description: 
The bin/merge-pull-request.py script could use the following improvements:
1. Fetch reviewer names and email 
2. Validate that the PR is approved by at least 1 committer. If there are -1, prompt on whether to proceed or not.
3. Prompt to override commit message - Sometimes, the description of the PR is very verbose and contains code. We can avoid really long commit messages here. 
4. Use upcoming release version as the default fixed version
5. Override commit message suggests "JIRA-ID; message" with a semicolon. Seems our convention is to use a colon.




  was:
The bin/merge-pull-request.py script could use the following improvements:
1. Fetch reviewer names and email 
2. Validate that the PR is approved by at least 1 committer. If there are -1, prompt on whether to proceed or not.
3. Prompt to override commit message - Sometimes, the description of the PR is very verbose and contains code. We can avoid really long commit messages here. 





> Improvements to Merge Script
> ----------------------------
>
>                 Key: SAMZA-1184
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1184
>             Project: Samza
>          Issue Type: Sub-task
>            Reporter: Navina Ramesh
>
> The bin/merge-pull-request.py script could use the following improvements:
> 1. Fetch reviewer names and email 
> 2. Validate that the PR is approved by at least 1 committer. If there are -1, prompt on whether to proceed or not.
> 3. Prompt to override commit message - Sometimes, the description of the PR is very verbose and contains code. We can avoid really long commit messages here. 
> 4. Use upcoming release version as the default fixed version
> 5. Override commit message suggests "JIRA-ID; message" with a semicolon. Seems our convention is to use a colon.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)