You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "starocean999 (via GitHub)" <gi...@apache.org> on 2026/05/15 06:21:11 UTC
[PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
starocean999 opened a new pull request, #63281:
URL: https://github.com/apache/doris/pull/63281
Problem Summary:
TIMESTAMPTZ range partition bounds with explicit offsets were still inconsistent across FE paths.
`CREATE TABLE ... PARTITION BY RANGE ... VALUES LESS THAN ('2024-01-15 13:00:00 +00:00')`
failed because the raw bound string was reparsed by `PartitionKey` and rejected the space before the
timezone offset. This also overlaps with the existing TIMESTAMPTZ partition-boundary handling that
must preserve explicit UTC offsets during metadata reconstruction.
This PR normalizes spaced numeric timezone offsets in the TIMESTAMPTZ partition-key parsing path and
adds focused FE unit tests plus regression coverage for:
- direct TIMESTAMPTZ partition key parsing with explicit offsets
- CREATE TABLE with VALUES LESS THAN TIMESTAMPTZ bounds
- CREATE TABLE LIKE round-trip preservation of TIMESTAMPTZ range boundaries
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4457737577
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4498428865
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4475456248
<details>
<summary>TPC-DS: <b>Total hot run time: 170545 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 871ed02e830857ab4a8a99febfd306b00b6346c8, data reload: false
query5 4327 648 517 517
query6 324 238 222 222
query7 4232 528 294 294
query8 336 243 226 226
query9 8843 4020 4053 4020
query10 454 344 300 300
query11 5792 2346 2207 2207
query12 182 132 127 127
query13 1278 603 439 439
query14 6049 5410 5052 5052
query14_1 4363 4382 4359 4359
query15 217 207 183 183
query16 1006 466 444 444
query17 1155 752 606 606
query18 2597 494 371 371
query19 228 208 175 175
query20 142 133 129 129
query21 222 150 122 122
query22 13567 13568 13396 13396
query23 17224 16432 16036 16036
query23_1 16265 16179 16134 16134
query24 7528 1762 1287 1287
query24_1 1307 1300 1315 1300
query25 569 505 455 455
query26 1317 337 173 173
query27 2679 579 347 347
query28 4418 1945 1922 1922
query29 1027 649 531 531
query30 310 239 211 211
query31 1117 1061 933 933
query32 96 74 78 74
query33 560 364 302 302
query34 1227 1118 625 625
query35 757 773 674 674
query36 1348 1312 1203 1203
query37 154 104 99 99
query38 3196 3134 3017 3017
query39 930 932 885 885
query39_1 876 882 877 877
query40 229 148 124 124
query41 77 75 61 61
query42 112 109 107 107
query43 327 319 293 293
query44
query45 210 204 194 194
query46 1032 1224 721 721
query47 2416 2335 2211 2211
query48 377 400 301 301
query49 628 492 384 384
query50 1005 339 265 265
query51 4310 4253 4273 4253
query52 103 105 94 94
query53 248 272 202 202
query54 315 264 254 254
query55 92 89 83 83
query56 316 317 315 315
query57 1436 1433 1307 1307
query58 292 266 263 263
query59 1566 1605 1455 1455
query60 328 330 327 327
query61 155 159 161 159
query62 671 621 536 536
query63 244 203 201 201
query64 2396 823 622 622
query65
query66 1725 469 352 352
query67 29922 29871 29804 29804
query68
query69 463 337 313 313
query70 1028 961 1027 961
query71 304 274 265 265
query72 2994 2657 2700 2657
query73 826 741 399 399
query74 5065 4929 4746 4746
query75 2692 2599 2261 2261
query76 2300 1132 757 757
query77 398 403 327 327
query78 12074 12150 11641 11641
query79 1473 1034 791 791
query80 689 537 449 449
query81 451 285 236 236
query82 1419 162 128 128
query83 353 278 245 245
query84 268 135 114 114
query85 901 549 457 457
query86 392 366 322 322
query87 3428 3337 3229 3229
query88 3506 2669 2636 2636
query89 449 391 334 334
query90 1946 183 172 172
query91 180 165 134 134
query92 83 79 78 78
query93 1480 1406 924 924
query94 557 337 304 304
query95 679 371 343 343
query96 1065 851 337 337
query97 2696 2677 2563 2563
query98 237 248 228 228
query99 1102 1117 1026 1026
Total cold run time: 253093 ms
Total hot run time: 170545 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4496850462
<details>
<summary>TPC-DS: <b>Total hot run time: 170797 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 33717f0b96bc926640acebb549ea708df32368a5, data reload: false
query5 4335 659 509 509
query6 339 223 201 201
query7 4231 582 302 302
query8 336 232 215 215
query9 8788 4045 4042 4042
query10 464 332 300 300
query11 5744 2645 2229 2229
query12 187 133 130 130
query13 1286 571 412 412
query14 5989 5362 5079 5079
query14_1 4342 4358 4345 4345
query15 209 207 178 178
query16 1023 443 385 385
query17 1148 708 579 579
query18 2476 504 376 376
query19 208 214 168 168
query20 142 129 132 129
query21 223 134 123 123
query22 13657 13523 13476 13476
query23 17143 16494 16021 16021
query23_1 16201 16252 16186 16186
query24 7442 1773 1305 1305
query24_1 1294 1273 1340 1273
query25 550 478 412 412
query26 1346 329 176 176
query27 2709 583 345 345
query28 4472 1957 1948 1948
query29 1015 668 548 548
query30 304 245 202 202
query31 1112 1058 942 942
query32 95 82 74 74
query33 563 370 315 315
query34 1208 1148 661 661
query35 775 797 672 672
query36 1335 1375 1163 1163
query37 164 113 96 96
query38 3206 3152 3072 3072
query39 939 924 899 899
query39_1 876 913 929 913
query40 231 152 136 136
query41 72 69 68 68
query42 118 111 114 111
query43 332 331 286 286
query44
query45 214 202 205 202
query46 1098 1207 753 753
query47 2375 2361 2207 2207
query48 407 419 297 297
query49 629 481 387 387
query50 998 357 250 250
query51 4350 4311 4279 4279
query52 105 107 99 99
query53 268 283 197 197
query54 309 275 255 255
query55 92 90 87 87
query56 300 302 322 302
query57 1425 1434 1327 1327
query58 306 271 276 271
query59 1577 1731 1455 1455
query60 327 323 310 310
query61 157 156 155 155
query62 674 609 565 565
query63 246 207 212 207
query64 2396 824 641 641
query65
query66 1744 511 354 354
query67 30005 30129 29981 29981
query68
query69 471 335 309 309
query70 1050 1015 988 988
query71 314 281 274 274
query72 3107 2678 2446 2446
query73 805 773 428 428
query74 5034 4928 4755 4755
query75 2684 2617 2247 2247
query76 2304 1138 762 762
query77 407 419 336 336
query78 12069 12067 11643 11643
query79 1454 1016 756 756
query80 688 526 452 452
query81 448 277 239 239
query82 1355 161 126 126
query83 349 273 251 251
query84 260 143 110 110
query85 868 539 448 448
query86 409 359 332 332
query87 3513 3388 3213 3213
query88 3514 2634 2595 2595
query89 440 388 332 332
query90 1947 183 186 183
query91 180 168 141 141
query92 80 76 75 75
query93 1573 1467 886 886
query94 548 352 322 322
query95 680 383 455 383
query96 1000 772 316 316
query97 2723 2706 2598 2598
query98 246 233 245 233
query99 1096 1122 1002 1002
Total cold run time: 253057 ms
Total hot run time: 170797 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4499578558
<details>
<summary>TPC-H: <b>Total hot run time: 30771 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0beb5d2347dda0092f7a9a51f985275ebe88f02e, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17771 3985 3983 3983
q2 q3 10790 1371 800 800
q4 4682 475 351 351
q5 7606 2248 2100 2100
q6 283 175 138 138
q7 987 789 629 629
q8 9509 1807 1651 1651
q9 6801 4935 4828 4828
q10 6449 2101 1788 1788
q11 452 275 240 240
q12 685 422 294 294
q13 18268 3398 2711 2711
q14 266 252 240 240
q15 q16 824 769 698 698
q17 989 914 947 914
q18 6897 5849 5493 5493
q19 1217 1308 1015 1015
q20 532 402 267 267
q21 5817 2623 2319 2319
q22 423 360 312 312
Total cold run time: 101248 ms
Total hot run time: 30771 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4327 4208 4252 4208
q2 q3 4514 4933 4315 4315
q4 2092 2224 1381 1381
q5 4428 4307 4478 4307
q6 326 214 157 157
q7 2107 1765 1673 1673
q8 2479 2129 2052 2052
q9 7845 7872 7830 7830
q10 4522 4493 4045 4045
q11 790 403 368 368
q12 722 726 516 516
q13 3412 3577 3038 3038
q14 289 312 311 311
q15 q16 738 745 625 625
q17 1363 1342 1326 1326
q18 7972 7376 6811 6811
q19 1117 1104 1112 1104
q20 2200 2217 1934 1934
q21 5320 4675 4498 4498
q22 514 473 420 420
Total cold run time: 57077 ms
Total hot run time: 50919 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4501368283
# FE Regression Coverage Report
Increment line coverage ` 100.00% (18/18)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63281_5735cfe30acf9def434e228b0d204310125accd9_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63281_5735cfe30acf9def434e228b0d204310125accd9_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 closed pull request #63281: [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds
URL: https://github.com/apache/doris/pull/63281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4499667062
<details>
<summary>TPC-DS: <b>Total hot run time: 168781 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0beb5d2347dda0092f7a9a51f985275ebe88f02e, data reload: false
query5 4332 649 527 527
query6 334 228 207 207
query7 4256 563 306 306
query8 325 245 221 221
query9 8837 4067 4045 4045
query10 449 340 302 302
query11 5768 2418 2273 2273
query12 187 136 133 133
query13 1322 596 437 437
query14 6029 5398 5054 5054
query14_1 4398 4399 4333 4333
query15 218 206 188 188
query16 1015 449 424 424
query17 1122 752 609 609
query18 2468 497 368 368
query19 223 209 170 170
query20 145 136 135 135
query21 219 144 123 123
query22 13580 13469 13355 13355
query23 17252 16402 15959 15959
query23_1 16157 16092 16206 16092
query24 7519 1759 1269 1269
query24_1 1273 1285 1290 1285
query25 546 459 406 406
query26 1320 326 172 172
query27 2679 577 334 334
query28 4437 1979 1936 1936
query29 1000 636 500 500
query30 302 234 197 197
query31 1107 1058 929 929
query32 88 75 72 72
query33 528 353 294 294
query34 1167 1120 640 640
query35 773 792 656 656
query36 1328 1345 1204 1204
query37 151 103 89 89
query38 3190 3173 3081 3081
query39 933 913 919 913
query39_1 925 895 883 883
query40 228 150 123 123
query41 64 78 76 76
query42 116 112 110 110
query43 325 330 285 285
query44
query45 212 199 194 194
query46 1120 1219 733 733
query47 2353 2335 2179 2179
query48 390 409 317 317
query49 627 487 390 390
query50 994 356 257 257
query51 4299 4292 4200 4200
query52 106 105 98 98
query53 258 284 205 205
query54 328 282 266 266
query55 97 90 87 87
query56 293 317 313 313
query57 1410 1413 1311 1311
query58 309 272 270 270
query59 1547 1608 1405 1405
query60 329 328 308 308
query61 169 159 161 159
query62 660 635 563 563
query63 244 200 212 200
query64 2403 802 664 664
query65
query66 1734 481 356 356
query67 29946 29334 29759 29334
query68
query69 455 348 312 312
query70 1013 961 1039 961
query71 301 285 271 271
query72 3005 2802 2399 2399
query73 863 777 423 423
query74 5089 4903 4730 4730
query75 2672 2579 2264 2264
query76 2296 1129 735 735
query77 391 414 335 335
query78 12081 12190 11630 11630
query79 1277 1069 745 745
query80 577 549 460 460
query81 446 274 236 236
query82 237 157 119 119
query83 364 278 249 249
query84 281 141 111 111
query85 865 534 455 455
query86 362 336 294 294
query87 3393 3405 3190 3190
query88 3505 2659 2637 2637
query89 418 388 346 346
query90 2171 176 175 175
query91 177 168 138 138
query92 81 76 74 74
query93 1419 1493 884 884
query94 542 358 314 314
query95 680 399 443 399
query96 1079 814 344 344
query97 2684 2677 2546 2546
query98 234 233 227 227
query99 1110 1089 986 986
Total cold run time: 251614 ms
Total hot run time: 168781 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4457450760
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4457451301
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4475533619
# FE Regression Coverage Report
Increment line coverage ` 33.33% (17/51)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63281_871ed02e830857ab4a8a99febfd306b00b6346c8_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63281_871ed02e830857ab4a8a99febfd306b00b6346c8_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4500248446
<details>
<summary>TPC-DS: <b>Total hot run time: 169231 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5735cfe30acf9def434e228b0d204310125accd9, data reload: false
query5 4305 661 518 518
query6 335 216 200 200
query7 4262 568 323 323
query8 340 228 216 216
query9 8834 4098 4076 4076
query10 433 343 301 301
query11 5845 2404 2234 2234
query12 190 134 130 130
query13 1302 615 450 450
query14 6019 5399 5044 5044
query14_1 4373 4412 4384 4384
query15 240 202 185 185
query16 977 447 440 440
query17 1121 716 582 582
query18 2438 488 348 348
query19 213 207 167 167
query20 139 133 130 130
query21 213 139 117 117
query22 13622 13493 13300 13300
query23 17188 16334 15938 15938
query23_1 16061 16056 16168 16056
query24 7557 1754 1314 1314
query24_1 1298 1295 1320 1295
query25 541 472 407 407
query26 1313 325 172 172
query27 2701 553 360 360
query28 4432 1952 1930 1930
query29 958 636 492 492
query30 310 234 203 203
query31 1110 1069 955 955
query32 99 73 72 72
query33 528 357 293 293
query34 1165 1124 639 639
query35 768 777 662 662
query36 1308 1347 1158 1158
query37 160 110 93 93
query38 3206 3125 3061 3061
query39 935 932 900 900
query39_1 890 882 886 882
query40 242 152 134 134
query41 72 83 68 68
query42 118 114 113 113
query43 325 329 292 292
query44
query45 215 206 199 199
query46 1110 1241 738 738
query47 2271 2302 2225 2225
query48 426 416 299 299
query49 655 504 407 407
query50 1018 383 256 256
query51 4271 4404 4301 4301
query52 112 108 99 99
query53 254 284 215 215
query54 332 287 282 282
query55 96 94 88 88
query56 321 315 336 315
query57 1410 1426 1311 1311
query58 315 297 282 282
query59 1536 1602 1411 1411
query60 337 344 323 323
query61 186 182 183 182
query62 670 627 575 575
query63 246 210 212 210
query64 2479 869 686 686
query65
query66 1709 472 350 350
query67 30034 29926 29752 29752
query68
query69 451 350 291 291
query70 1047 993 996 993
query71 299 275 259 259
query72 3051 2738 2382 2382
query73 835 758 429 429
query74 5066 4877 4715 4715
query75 2686 2614 2276 2276
query76 2291 1165 799 799
query77 401 424 339 339
query78 12233 12254 11608 11608
query79 1512 1033 733 733
query80 1206 551 459 459
query81 504 278 233 233
query82 1449 158 117 117
query83 357 283 249 249
query84 264 145 113 113
query85 982 551 461 461
query86 438 333 336 333
query87 3407 3376 3216 3216
query88 3526 2729 2686 2686
query89 440 395 338 338
query90 1771 187 186 186
query91 184 167 138 138
query92 83 75 74 74
query93 1520 1542 823 823
query94 649 367 315 315
query95 678 385 372 372
query96 1026 785 347 347
query97 2698 2710 2539 2539
query98 243 235 236 235
query99 1103 1102 941 941
Total cold run time: 253535 ms
Total hot run time: 169231 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4498020117
# FE Regression Coverage Report
Increment line coverage ` 96.55% (28/29)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63281_a7e75edee34ed49a3b09bc10085c0281568d3229_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63281_a7e75edee34ed49a3b09bc10085c0281568d3229_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4498429797
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4458829767
# FE Regression Coverage Report
Increment line coverage ` 42.50% (17/40)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63281_739adfcded87864c23b0267fa5959362007c018a_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63281_739adfcded87864c23b0267fa5959362007c018a_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #63281:
URL: https://github.com/apache/doris/pull/63281#discussion_r3274047278
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/StringLikeLiteral.java:
##########
@@ -148,20 +145,12 @@ protected Expression uncheckedCastTo(DataType targetType) throws AnalysisExcepti
return new DateTimeLiteral((DateTimeType) targetType, datetime.year, datetime.month, datetime.day,
datetime.hour, datetime.minute, datetime.second, datetime.microSecond);
} else if (targetType.isTimeStampTzType()) {
- // Explicit offsets must not round-trip through session local time; that loses the selected
- // branch in DST fold hours. Wildcard targets still need a concrete scale before parsing.
+ // Wildcard targets still need a concrete scale before parsing.
TimeStampTzType timeStampTzType = (TimeStampTzType) targetType;
if (timeStampTzType.getScale() < 0) {
timeStampTzType = TimeStampTzType.forTypeFromString(value);
}
- if (DateTimeChecker.hasTimeZone(value)) {
- return new TimestampTzLiteral(timeStampTzType, value);
- }
- DateTimeV2Literal expression = castToDateTime(DateTimeV2Type.MAX, strictCast, true);
- expression = (DateTimeV2Literal) (DateTimeExtractAndTransform.convertTz(expression,
- new StringLiteral(ConnectContext.get().getSessionVariable().timeZone), new StringLiteral("UTC")));
- return new TimestampTzLiteral(timeStampTzType, expression.year, expression.month,
- expression.day, expression.hour, expression.minute, expression.second, expression.microSecond);
Review Comment:
This no-offset TIMESTAMPTZ cast path no longer honors `enable_strict_cast`. Before this change, strings without an explicit zone went through `castToDateTime(DateTimeV2Type.MAX, strictCast, true)`, so strict mode used `dateStrictPattern` and rejected unstrict datetime spellings. Now `fromSessionTimeZone()` constructs `new DateTimeV2Literal(s)` directly, bypassing the `strictCast` flag while the DATETIME/DATETIMEV2 branches above still use `castToDateTime(..., strictCast, ...)`. As a result `CAST(... AS TIMESTAMPTZ)` can accept no-offset formats under `enable_strict_cast=true` that equivalent DATETIMEV2 casts and the previous TIMESTAMPTZ implementation reject. Please preserve the old `castToDateTime` strict parsing for the no-explicit-timezone branch, then convert that parsed value from the session timezone to UTC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4499729810
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4496950839
<details>
<summary>TPC-DS: <b>Total hot run time: 169275 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a7e75edee34ed49a3b09bc10085c0281568d3229, data reload: false
query5 4353 648 509 509
query6 333 222 212 212
query7 4257 570 307 307
query8 328 228 214 214
query9 8828 3956 3984 3956
query10 453 340 293 293
query11 5750 2410 2232 2232
query12 179 133 128 128
query13 1289 572 451 451
query14 5999 5396 5061 5061
query14_1 4366 4343 4301 4301
query15 212 205 188 188
query16 1008 466 429 429
query17 1111 697 576 576
query18 2534 492 355 355
query19 214 204 171 171
query20 135 133 126 126
query21 213 140 112 112
query22 13635 13598 13565 13565
query23 17084 16385 16064 16064
query23_1 16147 16181 16233 16181
query24 7439 1747 1271 1271
query24_1 1304 1299 1286 1286
query25 541 468 407 407
query26 1309 335 171 171
query27 2696 561 342 342
query28 4474 1913 1904 1904
query29 1014 609 483 483
query30 303 243 207 207
query31 1148 1077 935 935
query32 94 81 75 75
query33 566 356 296 296
query34 1256 1133 647 647
query35 780 789 672 672
query36 1325 1352 1238 1238
query37 158 100 94 94
query38 3204 3175 3057 3057
query39 931 921 895 895
query39_1 886 888 869 869
query40 248 154 127 127
query41 72 70 68 68
query42 114 113 111 111
query43 319 333 289 289
query44
query45 216 213 199 199
query46 1082 1162 744 744
query47 2294 2364 2229 2229
query48 412 420 315 315
query49 674 528 390 390
query50 1028 355 246 246
query51 4364 4249 4327 4249
query52 105 108 95 95
query53 245 277 201 201
query54 315 269 248 248
query55 92 89 85 85
query56 298 308 302 302
query57 1407 1377 1334 1334
query58 299 268 262 262
query59 1547 1679 1408 1408
query60 322 330 314 314
query61 153 151 151 151
query62 668 626 556 556
query63 240 194 203 194
query64 2432 780 598 598
query65
query66 1698 476 338 338
query67 30214 29920 29936 29920
query68
query69 460 333 309 309
query70 1041 949 934 934
query71 304 285 280 280
query72 3064 2653 2343 2343
query73 851 767 429 429
query74 5059 4870 4732 4732
query75 2662 2586 2249 2249
query76 2309 1146 766 766
query77 389 404 327 327
query78 12011 12039 11583 11583
query79 1448 1041 769 769
query80 695 525 463 463
query81 474 280 234 234
query82 1369 161 119 119
query83 353 275 258 258
query84 264 140 108 108
query85 885 528 452 452
query86 400 338 338 338
query87 3405 3428 3238 3238
query88 3553 2655 2650 2650
query89 434 379 341 341
query90 1900 167 177 167
query91 181 170 140 140
query92 76 80 74 74
query93 1561 1487 833 833
query94 549 366 289 289
query95 675 375 453 375
query96 1088 773 368 368
query97 2719 2694 2601 2601
query98 237 230 233 230
query99 1138 1104 994 994
Total cold run time: 253103 ms
Total hot run time: 169275 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4457913157
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4473570123
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4533246977
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4533632460
<details>
<summary>TPC-DS: <b>Total hot run time: 173075 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 856591115a350c7ab2f3c92eb4bf62d4c9321871, data reload: false
query5 4334 656 532 532
query6 346 215 211 211
query7 4251 551 303 303
query8 339 238 229 229
query9 8815 4172 4143 4143
query10 442 338 303 303
query11 5802 2822 2215 2215
query12 181 126 125 125
query13 1359 619 444 444
query14 6154 5540 5255 5255
query14_1 4617 4558 4580 4558
query15 217 208 185 185
query16 991 461 453 453
query17 993 743 618 618
query18 2474 508 364 364
query19 227 217 173 173
query20 145 135 132 132
query21 225 142 117 117
query22 13734 13593 13381 13381
query23 17425 16618 16204 16204
query23_1 16474 16344 16500 16344
query24 7497 1791 1327 1327
query24_1 1330 1329 1319 1319
query25 595 510 451 451
query26 1347 327 173 173
query27 2691 532 341 341
query28 4448 2027 2037 2027
query29 1034 646 520 520
query30 307 240 200 200
query31 1142 1089 950 950
query32 88 80 77 77
query33 553 362 314 314
query34 1195 1132 650 650
query35 777 802 682 682
query36 1390 1385 1259 1259
query37 151 102 93 93
query38 3234 3177 3034 3034
query39 936 951 905 905
query39_1 872 880 901 880
query40 240 146 124 124
query41 65 63 61 61
query42 113 118 116 116
query43 336 338 291 291
query44
query45 212 208 198 198
query46 1079 1163 748 748
query47 2338 2439 2201 2201
query48 404 419 298 298
query49 631 495 383 383
query50 962 352 253 253
query51 4379 4356 4375 4356
query52 106 107 97 97
query53 259 296 206 206
query54 310 271 253 253
query55 96 95 87 87
query56 303 298 305 298
query57 1436 1410 1318 1318
query58 303 276 276 276
query59 1660 1655 1501 1501
query60 328 336 315 315
query61 161 156 159 156
query62 697 662 589 589
query63 241 204 220 204
query64 2425 812 643 643
query65
query66 1731 480 354 354
query67 30095 30014 29833 29833
query68
query69 463 349 317 317
query70 1096 1024 1017 1017
query71 315 274 273 273
query72 3055 2710 2393 2393
query73 838 796 403 403
query74 5136 4978 4822 4822
query75 2706 2607 2275 2275
query76 2275 1155 796 796
query77 409 423 346 346
query78 12579 12564 11871 11871
query79 1439 1054 787 787
query80 644 538 463 463
query81 455 286 241 241
query82 1397 159 126 126
query83 360 275 249 249
query84 304 143 115 115
query85 898 576 458 458
query86 408 319 340 319
query87 3438 3381 3244 3244
query88 3646 2757 2732 2732
query89 443 390 346 346
query90 1953 172 190 172
query91 181 172 139 139
query92 84 82 77 77
query93 1527 1530 913 913
query94 538 345 308 308
query95 704 486 372 372
query96 1098 788 346 346
query97 2762 2716 2602 2602
query98 240 229 224 224
query99 1204 1155 1027 1027
Total cold run time: 255677 ms
Total hot run time: 173075 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4533702801
# FE UT Coverage Report
Increment line coverage ` 88.89% (16/18)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63281_856591115a350c7ab2f3c92eb4bf62d4c9321871/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63281_856591115a350c7ab2f3c92eb4bf62d4c9321871/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4499103283
# FE UT Coverage Report
Increment line coverage ` 88.24% (15/17)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63281_0beb5d2347dda0092f7a9a51f985275ebe88f02e/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63281_0beb5d2347dda0092f7a9a51f985275ebe88f02e/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4500143409
<details>
<summary>TPC-H: <b>Total hot run time: 31101 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5735cfe30acf9def434e228b0d204310125accd9, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17641 3921 3836 3836
q2 q3 10783 1340 811 811
q4 4695 474 347 347
q5 7554 2269 2116 2116
q6 331 176 141 141
q7 950 790 631 631
q8 9362 1728 1628 1628
q9 6913 4932 4922 4922
q10 6455 2111 1812 1812
q11 430 275 250 250
q12 698 431 309 309
q13 18200 3424 2816 2816
q14 263 256 233 233
q15 q16 818 765 701 701
q17 1006 1006 916 916
q18 6807 5725 5512 5512
q19 1204 1309 1165 1165
q20 540 410 255 255
q21 5774 2540 2394 2394
q22 442 360 306 306
Total cold run time: 100866 ms
Total hot run time: 31101 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4163 4143 4059 4059
q2 q3 4496 4908 4300 4300
q4 2089 2194 1393 1393
q5 4416 4262 4305 4262
q6 229 178 130 130
q7 2293 1907 1685 1685
q8 2486 2074 2106 2074
q9 7831 7756 7697 7697
q10 4534 4509 4067 4067
q11 579 404 527 404
q12 721 750 512 512
q13 3345 3647 3055 3055
q14 300 316 292 292
q15 q16 743 732 653 653
q17 1359 1293 1356 1293
q18 7863 7295 7047 7047
q19 1149 1073 1150 1073
q20 2227 2216 1942 1942
q21 5323 4652 4439 4439
q22 525 466 400 400
Total cold run time: 56671 ms
Total hot run time: 50777 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4496828098
<details>
<summary>TPC-H: <b>Total hot run time: 31172 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a7e75edee34ed49a3b09bc10085c0281568d3229, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17631 4096 4125 4096
q2 q3 10738 1430 793 793
q4 4679 473 353 353
q5 7642 2303 2125 2125
q6 264 184 142 142
q7 942 801 630 630
q8 9371 1695 1640 1640
q9 6977 4971 4920 4920
q10 6457 2101 1773 1773
q11 434 274 244 244
q12 687 423 317 317
q13 18207 3418 2794 2794
q14 268 259 232 232
q15 q16 817 771 705 705
q17 990 937 953 937
q18 6928 5707 5474 5474
q19 1185 1332 1062 1062
q20 504 414 259 259
q21 5833 2644 2371 2371
q22 437 366 305 305
Total cold run time: 100991 ms
Total hot run time: 31172 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4347 4349 4314 4314
q2 q3 4511 4901 4296 4296
q4 2092 2203 1385 1385
q5 4433 4304 4663 4304
q6 260 203 140 140
q7 2036 1789 1649 1649
q8 2447 2173 2199 2173
q9 7830 7686 7757 7686
q10 4601 4470 4045 4045
q11 765 418 391 391
q12 725 725 529 529
q13 3447 3613 3044 3044
q14 285 293 273 273
q15 q16 736 774 661 661
q17 1389 1325 1328 1325
q18 8068 7307 7003 7003
q19 1117 1142 1116 1116
q20 2231 2229 1947 1947
q21 5331 4655 4554 4554
q22 543 492 437 437
Total cold run time: 57194 ms
Total hot run time: 51272 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #63281:
URL: https://github.com/apache/doris/pull/63281#discussion_r3271811995
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/PartitionKey.java:
##########
@@ -147,11 +147,14 @@ private static Literal getDateTimeLiteral(String value, Type type) throws Analys
} else if (type.isDatetimeV2()) {
return new DateTimeV2Literal(value);
} else if (type.isTimeStampTz()) {
+ if (hasExplicitTimeZone(value)) {
+ return new TimestampTzLiteral((TimeStampTzType) DataType.fromCatalogType(type), value);
Review Comment:
为啥不能全都直接这么搞？这种转换逻辑感觉应该隐藏在构造函数里，这里特殊点有啥？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4496073368
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4496731011
<details>
<summary>TPC-H: <b>Total hot run time: 31241 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 33717f0b96bc926640acebb549ea708df32368a5, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17841 3861 3858 3858
q2 q3 10818 1398 820 820
q4 4715 472 353 353
q5 8278 2265 2111 2111
q6 382 178 143 143
q7 977 758 655 655
q8 9727 1761 1665 1665
q9 7025 4986 4906 4906
q10 6480 2150 1794 1794
q11 436 275 245 245
q12 634 445 297 297
q13 18110 3499 2825 2825
q14 265 262 238 238
q15 q16 810 771 710 710
q17 996 970 909 909
q18 6820 5858 5538 5538
q19 1181 1312 1150 1150
q20 519 413 260 260
q21 5583 2635 2458 2458
q22 452 366 306 306
Total cold run time: 102049 ms
Total hot run time: 31241 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4359 4124 4111 4111
q2 q3 4620 4901 4353 4353
q4 2123 2225 1395 1395
q5 4372 4252 4786 4252
q6 281 190 144 144
q7 1968 1766 1646 1646
q8 2420 2081 2091 2081
q9 7939 7986 7697 7697
q10 4510 4523 4335 4335
q11 566 413 370 370
q12 746 733 508 508
q13 3326 3649 3024 3024
q14 299 314 289 289
q15 q16 722 752 677 677
q17 1385 1340 1349 1340
q18 8004 7243 6787 6787
q19 1115 1097 1120 1097
q20 2203 2246 1952 1952
q21 5338 4654 4546 4546
q22 532 467 407 407
Total cold run time: 56828 ms
Total hot run time: 51011 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #63281:
URL: https://github.com/apache/doris/pull/63281#discussion_r3272397697
##########
regression-test/data/datatype_p0/timestamptz/test_timestamptz_partition_boundary_timezone.out:
##########
@@ -0,0 +1,27 @@
+-- This file is automatically generated. You should know what you did if you want to edit this
+-- !bug107_create_shift --
+2024-01-15 12:30:00.000000+00:00 1
+2024-01-15 13:30:00.000000+00:00 2
+
+-- !bug108_like --
+2024-01-15 12:30:00.000000+00:00 1
+2024-01-15 13:30:00.000000+00:00 2
+
+-- !bug110_src --
+2024-01-15 12:30:00.000000+00:00 1
+2024-01-15 13:30:00.000000+00:00 2
+
+-- !bug111_src --
+2024-01-15 17:30:00.000000+00:00 1
+2024-01-15 18:30:00.000000+00:00 2
+
+-- !bug113_direct_date_trunc_utc --
+2024-06-15 00:00:00.000000+00:00
+
+-- !bug113_auto_tz_range --
+2024-06-15 20:00:00.000000+00:00 1
+
+-- !bug114_named_lowercase_tz --
+2024-01-15 12:30:00.000000+00:00 1
+2024-01-15 13:30:00.000000+00:00 2
+
Review Comment:
`git diff --check` reports this as `new blank line at EOF`. Please remove the extra trailing blank line (or regenerate the `.out`) so the patch is whitespace-clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #63281:
URL: https://github.com/apache/doris/pull/63281#discussion_r3246315102
##########
fe/fe-core/src/test/java/org/apache/doris/catalog/PartitionKeyTest.java:
##########
@@ -287,4 +291,30 @@ public void testMaxValueToSql() throws Exception {
PartitionKey key = PartitionKey.createInfinityPartitionKey(allColumns, true);
Assert.assertEquals("(MAXVALUE, MAXVALUE, MAXVALUE, MAXVALUE, MAXVALUE, MAXVALUE, MAXVALUE)", key.toSql());
}
Review Comment:
This method declaration is over-indented and should fail FE checkstyle.
```suggestion
public void testTimestampTzPartitionKeyKeepsExplicitOffset() throws Exception {
```
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/PartitionKey.java:
##########
@@ -147,14 +142,8 @@ private static Literal getDateTimeLiteral(String value, Type type) throws Analys
} else if (type.isDatetimeV2()) {
return new DateTimeV2Literal(value);
} else if (type.isTimeStampTz()) {
- DateTimeV2Literal literal = new DateTimeV2Literal(value);
- DateTimeV2Literal dtV2Lit = (DateTimeV2Literal) (DateTimeExtractAndTransform.convertTz(
- literal,
- new StringLiteral(ConnectContext.get().getSessionVariable().timeZone),
- new StringLiteral("UTC")));
- return new TimestampTzLiteral((TimeStampTzType) DataType.fromCatalogType(type),
- dtV2Lit.getYear(), dtV2Lit.getMonth(), dtV2Lit.getDay(),
- dtV2Lit.getHour(), dtV2Lit.getMinute(), dtV2Lit.getSecond(), dtV2Lit.getMicroSecond());
+ return Literal.fromLegacyLiteral(DateLiteralUtils.createDateLiteral(
Review Comment:
This changes the existing TIMESTAMPTZ partition-boundary semantics when the DDL value has no explicit offset. The old path parsed the value as a DATETIMEV2 in the current session time zone and then converted it to UTC, so `SET time_zone='America/New_York'; PARTITION ... ('2024-01-15 12:00:00')` stored a 17:00 UTC boundary. `DateLiteralUtils.createDateLiteral(..., TIMESTAMPTZ)` only applies an offset when the string itself contains one; without an offset it keeps 12:00 as UTC. That will move existing partition boundaries by the session offset and can route rows to the wrong partition. Please preserve the session-time-zone conversion for values without an explicit zone/offset, and add a regression test for that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4534729197
# FE Regression Coverage Report
Increment line coverage ` 100.00% (18/18)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63281_856591115a350c7ab2f3c92eb4bf62d4c9321871_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63281_856591115a350c7ab2f3c92eb4bf62d4c9321871_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4498633897
<details>
<summary>TPC-H: <b>Total hot run time: 31303 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0beb5d2347dda0092f7a9a51f985275ebe88f02e, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17758 3938 3910 3910
q2 q3 10815 1441 825 825
q4 4685 465 346 346
q5 7531 2261 2135 2135
q6 226 177 137 137
q7 971 808 637 637
q8 9444 1671 1667 1667
q9 5265 5041 5075 5041
q10 6397 2060 1795 1795
q11 429 274 242 242
q12 652 431 295 295
q13 18156 3393 2746 2746
q14 265 266 238 238
q15 q16 816 775 711 711
q17 1007 996 914 914
q18 6996 5857 5593 5593
q19 1305 1216 985 985
q20 513 403 268 268
q21 5983 2625 2513 2513
q22 429 358 305 305
Total cold run time: 99643 ms
Total hot run time: 31303 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4167 4137 4149 4137
q2 q3 4519 4945 4312 4312
q4 2117 2213 1375 1375
q5 4388 4278 4309 4278
q6 230 177 130 130
q7 2183 1996 1708 1708
q8 2530 2174 2158 2158
q9 8075 7956 7710 7710
q10 4591 4556 4166 4166
q11 547 401 373 373
q12 724 728 550 550
q13 3298 3717 3019 3019
q14 314 296 277 277
q15 q16 713 724 646 646
q17 1339 1316 1311 1311
q18 7970 7248 7226 7226
q19 1192 1139 1155 1139
q20 2217 2224 1929 1929
q21 5259 4592 4467 4467
q22 524 456 421 421
Total cold run time: 56897 ms
Total hot run time: 51332 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4496421726
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4497404268
# FE UT Coverage Report
Increment line coverage ` 100.00% (29/29)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63281_a7e75edee34ed49a3b09bc10085c0281568d3229/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63281_a7e75edee34ed49a3b09bc10085c0281568d3229/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #63281:
URL: https://github.com/apache/doris/pull/63281#discussion_r3273047783
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimestampTzLiteral.java:
##########
@@ -64,6 +66,31 @@ public TimestampTzLiteral(TimeStampTzType dateType,
roundMicroSecond(dateType.getScale());
}
+ private void init(TimeStampTzType dateType, String s) {
Review Comment:
i don't think this is a acceptable change. for TimestampTzLiteral, we should always treat the parameter `s` as a UTC date time string. So we should not adjust time zone when init.
If u want to reduce the reduant code. maybe need a static function to handle the string representing the current time zone
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/PartitionExprUtil.java:
##########
@@ -261,6 +261,9 @@ private static PartitionValue getPartitionFromDate(Type partitionColumnType, Dat
timeString = String.format(DATETIME_FORMATTER,
dateLiteral.getYear(), dateLiteral.getMonth(), dateLiteral.getDay(),
dateLiteral.getHour(), dateLiteral.getMinute(), dateLiteral.getSecond());
+ if (partitionColumnType.isTimeStampTz()) {
+ timeString = dateLiteral.getStringValue(partitionColumnType);
Review Comment:
partition value string is used in too many place, add timezone to it is very dangerous
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4475383952
<details>
<summary>TPC-H: <b>Total hot run time: 31532 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 871ed02e830857ab4a8a99febfd306b00b6346c8, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17809 3956 3935 3935
q2 q3 10809 1395 807 807
q4 4685 473 344 344
q5 7621 2292 2145 2145
q6 235 173 138 138
q7 922 773 645 645
q8 9425 1657 1678 1657
q9 5133 4924 4936 4924
q10 6385 2076 1786 1786
q11 439 276 249 249
q12 626 425 297 297
q13 18084 3343 2772 2772
q14 266 258 239 239
q15 q16 826 769 722 722
q17 1006 946 967 946
q18 6981 5812 5667 5667
q19 1303 1219 1058 1058
q20 505 514 306 306
q21 6182 2879 2578 2578
q22 547 370 317 317
Total cold run time: 99789 ms
Total hot run time: 31532 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4570 4542 4501 4501
q2 q3 4882 5313 4581 4581
q4 2128 2193 1414 1414
q5 5032 4646 4634 4634
q6 230 171 134 134
q7 1893 1663 1537 1537
q8 2383 2114 2055 2055
q9 7659 7251 7209 7209
q10 4438 4391 3987 3987
q11 526 382 346 346
q12 700 723 512 512
q13 3045 3411 2776 2776
q14 280 272 258 258
q15 q16 683 715 633 633
q17 1257 1233 1235 1233
q18 7431 6849 6892 6849
q19 1101 1079 1111 1079
q20 2186 2214 1924 1924
q21 5347 4655 4472 4472
q22 523 458 404 404
Total cold run time: 56294 ms
Total hot run time: 50538 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4458110346
<details>
<summary>TPC-DS: <b>Total hot run time: 169236 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 739adfcded87864c23b0267fa5959362007c018a, data reload: false
query5 4320 667 515 515
query6 353 216 202 202
query7 4219 557 328 328
query8 334 230 216 216
query9 8816 4084 4081 4081
query10 464 349 307 307
query11 5809 2398 2198 2198
query12 191 129 131 129
query13 1277 616 443 443
query14 6032 5378 5082 5082
query14_1 4385 4382 4338 4338
query15 217 203 182 182
query16 1044 461 443 443
query17 1170 752 607 607
query18 2803 508 371 371
query19 245 211 165 165
query20 141 139 131 131
query21 218 143 124 124
query22 13615 13590 13335 13335
query23 17211 16452 16011 16011
query23_1 16229 16219 16208 16208
query24 7392 1756 1288 1288
query24_1 1305 1311 1336 1311
query25 575 502 434 434
query26 1337 317 174 174
query27 2727 589 343 343
query28 4412 1963 1967 1963
query29 1019 652 509 509
query30 309 246 204 204
query31 1123 1062 958 958
query32 96 78 77 77
query33 568 371 322 322
query34 1158 1107 654 654
query35 777 798 729 729
query36 1300 1354 1235 1235
query37 163 102 93 93
query38 3220 3167 3117 3117
query39 926 909 916 909
query39_1 889 883 862 862
query40 223 153 126 126
query41 66 64 62 62
query42 113 110 110 110
query43 328 343 292 292
query44
query45 212 207 193 193
query46 1053 1219 736 736
query47 2234 2284 2176 2176
query48 394 412 287 287
query49 628 495 381 381
query50 995 361 249 249
query51 4342 4296 4242 4242
query52 107 110 97 97
query53 263 281 208 208
query54 316 272 262 262
query55 93 90 88 88
query56 295 323 313 313
query57 1373 1389 1281 1281
query58 298 282 267 267
query59 1595 1636 1435 1435
query60 317 357 318 318
query61 158 152 155 152
query62 667 623 560 560
query63 241 204 207 204
query64 2487 842 697 697
query65
query66 1703 484 365 365
query67 30021 29353 29831 29353
query68
query69 466 362 316 316
query70 1028 1004 1015 1004
query71 311 277 273 273
query72 3005 2649 2365 2365
query73 865 776 444 444
query74 5075 4893 4765 4765
query75 2649 2599 2258 2258
query76 2305 1129 776 776
query77 403 406 336 336
query78 12124 12085 11468 11468
query79 1481 1014 733 733
query80 1232 534 460 460
query81 523 276 240 240
query82 932 155 122 122
query83 345 277 252 252
query84 259 137 113 113
query85 914 539 453 453
query86 456 357 336 336
query87 3518 3363 3235 3235
query88 3610 2662 2679 2662
query89 444 387 341 341
query90 1944 194 190 190
query91 189 158 137 137
query92 80 82 75 75
query93 1559 1396 833 833
query94 718 330 312 312
query95 682 386 432 386
query96 1028 757 338 338
query97 2695 2677 2580 2580
query98 238 231 233 231
query99 1088 1096 1026 1026
Total cold run time: 254127 ms
Total hot run time: 169236 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4473901276
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #63281:
URL: https://github.com/apache/doris/pull/63281#discussion_r3255969615
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/PartitionKey.java:
##########
@@ -147,11 +148,15 @@ private static Literal getDateTimeLiteral(String value, Type type) throws Analys
} else if (type.isDatetimeV2()) {
return new DateTimeV2Literal(value);
} else if (type.isTimeStampTz()) {
+ if (hasExplicitTimeZone(value)) {
+ return Literal.fromLegacyLiteral(DateLiteralUtils.createDateLiteral(
+ normalizeTimestampTzOffset(value), type), type);
Review Comment:
This new explicit-time-zone branch rejects valid TIMESTAMPTZ literals that use named or lowercase zones. `hasExplicitTimeZone()` returns true for values like `2024-01-15 12:00:00Asia/Shanghai` or `2024-01-15 12:00:00 utc`, so they are routed here, but `DateLiteralUtils` only detects uppercase letters as timezone names and `getTimeZoneSplitPos()` only walks uppercase letters and `/`. For `Asia/Shanghai` it computes an empty `tzString`, and for lowercase `utc` it does not strip the zone at all, so table creation fails even though the normal Nereids TIMESTAMPTZ parser accepts these forms (see the existing `DateTimeLiteralTest`/`TimestampTzLiteralTest` cases around `Asia/Shanghai` and `uTc`). Please parse explicit TIMESTAMPTZ partition values with the same TIMESTAMPTZ literal parser, or extend this path and its tests to cover named and lowercase zones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4474029984
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4458058722
<details>
<summary>TPC-H: <b>Total hot run time: 30922 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 739adfcded87864c23b0267fa5959362007c018a, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17630 3899 3835 3835
q2 q3 10744 1416 837 837
q4 4681 472 340 340
q5 7570 2277 2130 2130
q6 256 172 135 135
q7 922 760 629 629
q8 9365 1688 1654 1654
q9 6666 4889 4861 4861
q10 6460 2160 1787 1787
q11 437 272 241 241
q12 691 420 293 293
q13 18204 3387 2818 2818
q14 270 255 231 231
q15 q16 813 787 705 705
q17 1086 907 1021 907
q18 6901 5761 5436 5436
q19 1297 1288 1079 1079
q20 507 411 265 265
q21 5535 2580 2433 2433
q22 431 358 306 306
Total cold run time: 100466 ms
Total hot run time: 30922 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4168 4092 4071 4071
q2 q3 4460 4931 4282 4282
q4 2095 2176 1391 1391
q5 4594 4267 4284 4267
q6 235 171 130 130
q7 2197 1988 1712 1712
q8 2503 2086 2015 2015
q9 7823 7687 7771 7687
q10 4517 4539 4065 4065
q11 573 393 367 367
q12 874 748 510 510
q13 3272 3592 2985 2985
q14 295 307 263 263
q15 q16 711 725 721 721
q17 1322 1320 1307 1307
q18 7847 7555 7057 7057
q19 1110 1086 1098 1086
q20 2211 2226 1933 1933
q21 5259 4562 4497 4497
q22 540 462 403 403
Total cold run time: 56606 ms
Total hot run time: 50749 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4496072229
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4499829679
# FE Regression Coverage Report
Increment line coverage ` 44.44% (8/18)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63281_0beb5d2347dda0092f7a9a51f985275ebe88f02e_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63281_0beb5d2347dda0092f7a9a51f985275ebe88f02e_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4499728555
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Accept spaced TIMESTAMPTZ offsets in range partition bounds [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63281:
URL: https://github.com/apache/doris/pull/63281#issuecomment-4533560974
<details>
<summary>TPC-H: <b>Total hot run time: 31473 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 856591115a350c7ab2f3c92eb4bf62d4c9321871, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17756 4153 4052 4052
q2 q3 10780 1485 851 851
q4 4680 483 352 352
q5 7664 2313 2117 2117
q6 239 184 143 143
q7 991 793 681 681
q8 9384 1731 1629 1629
q9 5198 4953 4971 4953
q10 6414 2222 1876 1876
q11 439 277 252 252
q12 640 427 306 306
q13 18114 3328 2775 2775
q14 276 266 243 243
q15 q16 823 780 711 711
q17 907 869 999 869
q18 6803 5753 5641 5641
q19 1301 1323 1121 1121
q20 525 398 262 262
q21 5901 2708 2330 2330
q22 447 364 309 309
Total cold run time: 99282 ms
Total hot run time: 31473 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4475 4424 4317 4317
q2 q3 4572 4985 4418 4418
q4 2130 2287 1426 1426
q5 4478 4343 4626 4343
q6 288 210 160 160
q7 2146 1945 1718 1718
q8 2654 2328 2339 2328
q9 8329 8044 7889 7889
q10 4856 4807 4368 4368
q11 583 459 405 405
q12 786 793 569 569
q13 3354 3670 2970 2970
q14 314 303 269 269
q15 q16 715 771 656 656
q17 1445 1427 1513 1427
q18 8208 7301 7247 7247
q19 1184 1139 1111 1111
q20 2235 2240 1948 1948
q21 5362 4693 4556 4556
q22 533 457 415 415
Total cold run time: 58647 ms
Total hot run time: 52540 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org