You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/28 20:36:53 UTC

[GitHub] [incubator-superset] suddjian commented on pull request #9667: Fix api limits in react CRUD

suddjian commented on pull request #9667:
URL: https://github.com/apache/incubator-superset/pull/9667#issuecomment-620840959


   The react views are currently in a sort of "beta state" behind a feature flag, so I think changing the default limit on all endpoints as a hotfix for them is inappropriate. We should instead fix the react views to paginate correctly.
   
   If making the endpoint unlimited really is necessary as a short-term fix, it would be better to at least limit this to the specific endpoint(s) that are causing issues.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org