[GitHub] [accumulo] milleruntime commented on a change in pull request #2426: Add to Upgrader9to10 javadoc. Closes #1922

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #2426:
URL: https://github.com/apache/accumulo/pull/2426#discussion_r790785199



##########
File path: server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader9to10.java
##########
@@ -111,6 +111,31 @@
  * {@link #dropSortedMapWALFiles(ServerContext)}. For more information see the following issues:
  * <a href="https://github.com/apache/accumulo/issues/2117">#2117</a> and
  * <a href="https://github.com/apache/accumulo/issues/2179">#2179</a>
+ *
+ * The following methods were created for External compactions:
+ * {@link #createExternalCompactionNodes(ServerContext)}, {@link #setMetaTableProps(ServerContext)}

Review comment:
       I disagree. The upgrade code is specifically about past changes to code and is not clear what methods are doing what. But this documentation was more meant to be a bridge for to assist admins performing upgrades. It is a lot easier for an admin to find the line in the code an exception refers to (something they can even do in the browser) then to track git history. Do you have any specific suggestions?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org