[GitHub] himanshug commented on issue #6223: make COMPLEX column filterable in Druid code

[GitBox <gi...@apache.org>]

himanshug commented on issue #6223: make COMPLEX column filterable in Druid code
URL: https://github.com/apache/incubator-druid/pull/6223#issuecomment-415594030
 
 
   > Would it make sense to add a canFilter method to ColumnCapabilities to have a finer level of control than just mapping filterability directly to ValueType?
   
   Actually I think existence of `Filterable.FILTERABLE_TYPE` is redundant. For me, ColumnCapability.hasBitmapIndexes() is already the indication whether column supports filtering or not. So, one thing to do is to remove `Filterable.FILTERABLE_TYPE` altogether and adjust the code in `ColumnSelectorBitmapIndexSelector` to not use that.
   
   however, I would like to keep things simple for this PR and not cause any unwanted side effects as above suggestion needs to get tested appropriately.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org