You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/19 20:15:05 UTC

[GitHub] [solr] dweiss commented on a change in pull request #36: Allow configuring maven snapshots repository mirrors

dweiss commented on a change in pull request #36:
URL: https://github.com/apache/solr/pull/36#discussion_r597950033



##########
File path: gradle/defaults.gradle
##########
@@ -77,4 +68,13 @@ allprojects {
       }
     }
   }
+
+  // Repositories to fetch dependencies from.
+  repositories {

Review comment:
       Maybe check for a separate property "custom.snapshots.repo" and if it exists skip the "ApacheSnapshots" and define a "CustomRepository"? It's weird to just substitute the URL here. I'm not sure if a more elegant way of doing this exists (although there very likely must be one for folks behind corporate firewalls)...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org