You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhangstar333 (via GitHub)" <gi...@apache.org> on 2024/01/05 15:26:15 UTC
[PR] [improve](fe) add check for leg/lead function params [doris]
zhangstar333 opened a new pull request, #29617:
URL: https://github.com/apache/doris/pull/29617
## Proposed changes
leed/lag function
param 2 is const positive value
param 3 is const value
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1880466612
<details>
<summary>TPC-H: <b>Total hot run time: 38350 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ba74e36d073e900834cc4255b85bbe536c980e43, data reload: false
------ Round 1 ----------------------------------
q1 17711 4950 4959 4950
q2 2009 151 139 139
q3 10628 1142 1121 1121
q4 10474 798 789 789
q5 7814 2931 2909 2909
q6 203 124 124 124
q7 995 501 489 489
q8 9321 1955 1981 1955
q9 6458 6368 6342 6342
q10 8228 2968 2991 2968
q11 435 219 210 210
q12 384 235 225 225
q13 17997 3378 3390 3378
q14 240 203 208 203
q15 550 513 498 498
q16 451 394 397 394
q17 1000 713 579 579
q18 7292 6624 6628 6624
q19 1593 1513 1516 1513
q20 767 333 320 320
q21 2804 2315 2341 2315
q22 350 305 305 305
Total cold run time: 107704 ms
Total hot run time: 38350 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4989 4958 4931 4931
q2 337 229 247 229
q3 3260 3272 3299 3272
q4 2149 2063 2021 2021
q5 5766 5792 5753 5753
q6 209 115 116 115
q7 2313 1903 1918 1903
q8 3363 3409 3456 3409
q9 8744 8647 8656 8647
q10 3784 3825 3820 3820
q11 541 443 442 442
q12 793 617 640 617
q13 5023 3209 3169 3169
q14 283 290 275 275
q15 548 505 492 492
q16 534 501 471 471
q17 1852 1852 1846 1846
q18 8567 8369 8272 8272
q19 1593 1635 1616 1616
q20 2178 1945 1948 1945
q21 5519 5247 5331 5247
q22 489 455 493 455
Total cold run time: 62834 ms
Total hot run time: 58947 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1884303968
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.3 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 21.4 seconds inserted 10000000 Rows, about 467K ops/s
storage size: 17183793730 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1878893336
<details>
<summary>TPC-DS: <b>Total hot run time: 183432 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2147b7b17f5a70dc9f5ed51ad5e2baf367b9ce16, data reload: false
run tpcds-sf100 query with default conf and session variables
query1 939 349 327 327
query2 6575 2061 2041 2041
query3 6732 221 233 221
query4 26894 22444 22512 22444
query5 5862 619 623 619
query6 334 209 203 203
query7 4642 307 309 307
query8 248 230 226 226
query9 8802 2927 2904 2904
query10 575 324 319 319
query11 16223 15289 15780 15289
query12 172 101 93 93
query13 1634 342 351 342
query14 11839 7531 7638 7531
query15 259 232 230 230
query16 6396 332 362 332
query17 1712 521 518 518
query18 1969 292 301 292
query19 234 162 156 156
query20 116 99 100 99
query21 184 99 98 98
query22 4944 4843 4566 4566
query23 32255 31623 31371 31371
query24 12472 2993 2926 2926
query25 595 357 368 357
query26 1854 157 158 157
query27 2830 309 314 309
query28 6787 2160 2129 2129
query29 2095 434 417 417
query30 285 144 146 144
query31 1022 827 845 827
query32 130 77 85 77
query33 839 336 338 336
query34 849 469 468 468
query35 1015 867 788 788
query36 1354 1206 1240 1206
query37 204 88 94 88
query38 3527 3396 3358 3358
query39 1347 1282 1308 1282
query40 300 85 88 85
query41 39 39 38 38
query42 118 106 105 105
query43 549 526 509 509
query44 1229 810 811 810
query45 211 208 207 207
query46 1096 701 711 701
query47 1717 1682 1671 1671
query48 343 303 276 276
query49 1201 325 323 323
query50 774 367 375 367
query51 5546 5299 5263 5263
query52 106 97 95 95
query53 236 168 166 166
query54 1353 673 668 668
query55 117 100 103 100
query56 282 235 272 235
query57 1080 968 980 968
query58 313 280 275 275
query59 3004 2672 2721 2672
query60 343 300 299 299
query61 145 150 153 150
query62 608 533 440 440
query63 199 178 162 162
query64 6090 1785 1788 1785
query65 3402 3338 3345 3338
query66 1357 386 396 386
query67 15414 15482 15440 15440
query68 13838 539 532 532
query69 634 302 319 302
query70 2094 1627 1596 1596
query71 600 305 260 260
query72 5242 3457 3467 3457
query73 3189 331 344 331
query74 7114 6566 6572 6566
query75 5335 2274 2251 2251
query76 6462 1126 1215 1126
query77 828 345 326 326
query78 9077 8569 8433 8433
query79 2076 516 524 516
query80 557 346 343 343
query81 466 209 222 209
query82 225 113 108 108
query83 192 143 143 143
query84 260 55 55 55
query85 954 273 270 270
query86 438 385 440 385
query87 3649 3430 3513 3430
query88 3242 2494 2422 2422
query89 371 286 280 280
query90 1939 255 249 249
query91 122 99 97 97
query92 90 83 77 77
query93 1137 514 424 424
query94 915 219 243 219
query95 547 516 496 496
query96 650 339 339 339
query97 4358 4262 4193 4193
query98 252 231 212 212
query99 1186 854 854 854
Total cold run time: 301956 ms
Total hot run time: 183432 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1884306457
<details>
<summary>ClickBench: <b>Total hot run time: 30.76 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6c5745887088c3651eff5e3f422a2841d436c90c, data reload: false
query1 0.06 0.05 0.05
query2 0.06 0.02 0.02
query3 0.25 0.11 0.11
query4 1.78 0.12 0.10
query5 0.52 0.52 0.51
query6 1.40 0.64 0.64
query7 0.01 0.01 0.01
query8 0.04 0.03 0.02
query9 0.55 0.50 0.50
query10 0.54 0.55 0.55
query11 0.13 0.10 0.09
query12 0.12 0.09 0.09
query13 0.60 0.60 0.60
query14 0.78 0.79 0.80
query15 0.83 0.79 0.80
query16 0.35 0.36 0.36
query17 0.94 0.94 0.97
query18 0.26 0.25 0.25
query19 1.84 1.75 1.79
query20 0.01 0.01 0.01
query21 15.38 0.61 0.58
query22 2.43 2.74 1.94
query23 17.34 0.85 0.71
query24 7.25 1.09 0.64
query25 2.10 0.16 0.15
query26 0.14 0.13 0.14
query27 0.15 0.15 0.15
query28 8.85 0.82 0.81
query29 12.56 3.37 3.36
query30 0.53 0.49 0.49
query31 2.78 0.35 0.35
query32 3.41 0.49 0.49
query33 3.19 3.27 3.21
query34 15.90 4.20 4.12
query35 4.17 4.14 4.19
query36 1.09 1.05 1.04
query37 0.06 0.05 0.05
query38 0.03 0.02 0.03
query39 0.03 0.01 0.01
query40 0.15 0.14 0.13
query41 0.07 0.02 0.02
query42 0.02 0.02 0.02
query43 0.03 0.02 0.02
Total cold run time: 108.73 s
Total hot run time: 30.76 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1884150522
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1884177564
<details>
<summary>ClickBench: <b>Total hot run time: 30.88 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ad1fea2f74e4a7352101a4457f7ff72bc5b36bf7, data reload: false
query1 0.07 0.06 0.06
query2 0.05 0.03 0.02
query3 0.26 0.12 0.11
query4 1.76 0.11 0.11
query5 0.53 0.51 0.51
query6 1.34 0.63 0.64
query7 0.02 0.01 0.01
query8 0.03 0.02 0.02
query9 0.56 0.51 0.50
query10 0.56 0.54 0.54
query11 0.13 0.09 0.08
query12 0.11 0.09 0.08
query13 0.60 0.59 0.60
query14 0.77 0.80 0.78
query15 0.81 0.81 0.80
query16 0.36 0.35 0.36
query17 0.96 0.99 0.94
query18 0.25 0.26 0.24
query19 1.81 1.78 1.72
query20 0.01 0.01 0.02
query21 15.40 0.59 0.58
query22 2.59 1.90 2.67
query23 17.17 0.85 0.72
query24 2.52 1.00 3.45
query25 2.01 0.15 0.15
query26 0.13 0.14 0.13
query27 0.16 0.15 0.15
query28 10.35 0.82 0.82
query29 12.64 3.26 3.22
query30 0.58 0.50 0.50
query31 2.80 0.35 0.38
query32 3.35 0.48 0.49
query33 3.20 3.26 3.16
query34 15.92 4.17 4.16
query35 4.18 4.16 4.18
query36 1.11 1.06 1.05
query37 0.06 0.05 0.04
query38 0.04 0.02 0.02
query39 0.03 0.02 0.02
query40 0.16 0.13 0.13
query41 0.07 0.01 0.01
query42 0.02 0.01 0.02
query43 0.02 0.02 0.02
Total cold run time: 105.5 s
Total hot run time: 30.88 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1884309593
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 6c5745887088c3651eff5e3f422a2841d436c90c with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 13.8 seconds inserted 10000000 Rows, about 724K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #29617:
URL: https://github.com/apache/doris/pull/29617#discussion_r1443020256
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/window/Lead.java:
##########
@@ -90,9 +91,13 @@ public void checkLegalityBeforeTypeCoercion() {
return;
}
if (children().size() >= 2) {
- DataType offsetType = getOffset().getDataType();
- if (!offsetType.isNumericType()) {
- throw new AnalysisException("The offset of LEAD must be a number:" + this.toSql());
+ checkValidParams(child(1));
+ if (((Literal) getOffset()).getDouble() <= 0) {
Review Comment:
checkValidParams not ensure param is literal, so there maybe throw cast error.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/window/WindowFunction.java:
##########
@@ -46,11 +48,25 @@ public boolean equals(Object o) {
}
WindowFunction that = (WindowFunction) o;
return Objects.equals(getName(), that.getName())
- && Objects.equals(children, that.children);
+ && Objects.equals(children, that.children);
}
@Override
public int hashCode() {
return Objects.hash(getName(), children);
}
+
+ /**
+ * LAG/LEAD param must be const number
+ */
+ public void checkValidParams(Expression param) {
Review Comment:
protected is better
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/window/Lead.java:
##########
@@ -90,9 +91,13 @@ public void checkLegalityBeforeTypeCoercion() {
return;
}
if (children().size() >= 2) {
- DataType offsetType = getOffset().getDataType();
- if (!offsetType.isNumericType()) {
- throw new AnalysisException("The offset of LEAD must be a number:" + this.toSql());
+ checkValidParams(child(1));
Review Comment:
it is better to call getOffset here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1878970580
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.43 seconds
stream load tsv: 568 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 26.3 seconds inserted 10000000 Rows, about 380K ops/s
storage size: 17183934608 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1878847942
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1884179557
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit ad1fea2f74e4a7352101a4457f7ff72bc5b36bf7 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 14.2 seconds inserted 10000000 Rows, about 704K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1880477851
<details>
<summary>TPC-DS: <b>Total hot run time: 184067 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ba74e36d073e900834cc4255b85bbe536c980e43, data reload: false
run tpcds-sf100 query with default conf and session variables
query1 924 337 343 337
query2 6550 2217 2124 2124
query3 6716 225 227 225
query4 25791 22479 22533 22479
query5 5644 603 637 603
query6 337 213 212 212
query7 4639 307 293 293
query8 245 237 231 231
query9 8716 3026 2995 2995
query10 552 357 299 299
query11 16308 15594 15572 15572
query12 171 97 100 97
query13 1678 341 334 334
query14 12904 7609 7542 7542
query15 299 238 206 206
query16 6446 340 341 340
query17 1706 531 503 503
query18 1963 294 303 294
query19 273 156 161 156
query20 105 98 101 98
query21 184 92 90 90
query22 5080 4620 4807 4620
query23 31899 31232 31360 31232
query24 12138 2974 2955 2955
query25 596 367 368 367
query26 1766 179 175 175
query27 2819 322 312 312
query28 7310 2178 2175 2175
query29 2007 426 406 406
query30 293 142 149 142
query31 1052 804 823 804
query32 130 87 83 83
query33 857 337 350 337
query34 864 473 478 473
query35 978 877 889 877
query36 1391 1189 1194 1189
query37 226 94 84 84
query38 3472 3362 3369 3362
query39 1345 1424 1312 1312
query40 308 87 87 87
query41 46 36 39 36
query42 114 106 103 103
query43 560 533 531 531
query44 1187 813 815 813
query45 218 204 206 204
query46 1058 718 698 698
query47 1720 1724 1658 1658
query48 380 279 290 279
query49 1208 304 313 304
query50 732 374 332 332
query51 5374 5337 5264 5264
query52 108 97 103 97
query53 234 168 163 163
query54 1491 683 640 640
query55 110 98 93 93
query56 323 235 268 235
query57 1041 950 964 950
query58 307 280 278 278
query59 3127 2893 2913 2893
query60 325 296 318 296
query61 153 150 146 146
query62 570 467 467 467
query63 201 188 180 180
query64 6054 1733 1694 1694
query65 3413 3327 3367 3327
query66 1367 406 371 371
query67 15627 15324 15301 15301
query68 12877 565 564 564
query69 600 328 293 293
query70 1701 1537 1562 1537
query71 595 288 298 288
query72 5282 3426 3440 3426
query73 2915 343 353 343
query74 7025 6466 6523 6466
query75 5505 2281 2262 2262
query76 6331 1130 1199 1130
query77 743 307 342 307
query78 9044 8644 8536 8536
query79 1100 537 526 526
query80 573 345 346 345
query81 466 219 219 219
query82 238 105 102 102
query83 195 141 141 141
query84 260 59 59 59
query85 927 276 276 276
query86 426 424 425 424
query87 3646 3446 3442 3442
query88 3020 2498 2507 2498
query89 379 284 281 281
query90 1954 248 252 248
query91 123 95 94 94
query92 94 77 65 65
query93 1196 436 440 436
query94 921 249 243 243
query95 529 507 493 493
query96 661 363 354 354
query97 4300 4306 4262 4262
query98 249 223 214 214
query99 1151 842 818 818
Total cold run time: 298756 ms
Total hot run time: 184067 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1884262847
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1878880189
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
```
Tpch sf100 test result on commit 2147b7b17f5a70dc9f5ed51ad5e2baf367b9ce16, data reload: false
run tpch-sf100 query with default conf and session variables
q1 5495 5171 5100 5100
q2 382 172 158 158
q3 1451 1115 1122 1115
q4 1087 866 820 820
q5 3147 3150 3056 3056
q6 222 132 134 132
q7 969 553 520 520
q8 2169 2263 2253 2253
q9 6722 6659 6653 6653
q10 3193 3125 3092 3092
q11 336 217 219 217
q12 387 236 233 233
q13 4383 3668 3624 3624
q14 259 215 214 214
q15 576 529 526 526
q16 457 402 406 402
q17 1032 494 491 491
q18 7109 6726 6796 6726
q19 1644 1535 1596 1535
q20 598 326 328 326
q21 2877 2439 2436 2436
q22 383 322 341 322
Total cold run time: 44878 ms
Total hot run time: 39951 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 5156 5083 5087 5083
q2 345 233 236 233
q3 3352 3348 3300 3300
q4 2152 2039 2029 2029
q5 5928 5912 5904 5904
q6 227 123 128 123
q7 2396 1927 1956 1927
q8 3583 3641 3690 3641
q9 9035 8979 8930 8930
q10 3878 3897 3901 3897
q11 579 493 473 473
q12 796 634 640 634
q13 3861 3187 3198 3187
q14 297 264 290 264
q15 593 532 533 532
q16 566 516 508 508
q17 2020 1814 1850 1814
q18 8770 8332 8341 8332
q19 1738 1717 1665 1665
q20 2272 1988 1955 1955
q21 5686 5393 5345 5345
q22 560 514 485 485
Total cold run time: 63790 ms
Total hot run time: 60261 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1878893094
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.53 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 27.7 seconds inserted 10000000 Rows, about 361K ops/s
storage size: 17183516202 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1880502698
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.39 seconds
stream load tsv: 578 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 27.9 seconds inserted 10000000 Rows, about 358K ops/s
storage size: 17187656763 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1884175756
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.55 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 20.9 seconds inserted 10000000 Rows, about 478K ops/s
storage size: 17188949206 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1884290266
<details>
<summary>TPC-H: <b>Total hot run time: 38533 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6c5745887088c3651eff5e3f422a2841d436c90c, data reload: false
------ Round 1 ----------------------------------
q1 17989 5055 5046 5046
q2 2051 153 139 139
q3 10665 1084 1120 1084
q4 10250 800 857 800
q5 7856 3080 3206 3080
q6 203 123 123 123
q7 875 510 486 486
q8 9267 1945 1986 1945
q9 6568 6505 6413 6413
q10 8286 3078 3031 3031
q11 427 235 198 198
q12 363 195 202 195
q13 18109 3396 3432 3396
q14 240 220 211 211
q15 553 504 518 504
q16 428 383 374 374
q17 936 509 482 482
q18 7393 6673 6693 6673
q19 1564 1354 1370 1354
q20 521 303 324 303
q21 2830 2379 2379 2379
q22 367 327 317 317
Total cold run time: 107741 ms
Total hot run time: 38533 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4988 5010 5011 5010
q2 311 203 203 203
q3 3341 3317 3288 3288
q4 2213 2239 2250 2239
q5 5801 5795 5797 5795
q6 194 117 117 117
q7 2325 1866 1869 1866
q8 3444 3537 3583 3537
q9 8908 8849 8830 8830
q10 3757 3817 3815 3815
q11 563 441 444 441
q12 784 619 623 619
q13 5047 3250 3189 3189
q14 293 263 267 263
q15 554 517 511 511
q16 509 471 469 469
q17 2098 2071 2062 2062
q18 8745 8341 8306 8306
q19 1599 1578 1616 1578
q20 2161 1925 1935 1925
q21 6067 5671 5735 5671
q22 602 513 489 489
Total cold run time: 64304 ms
Total hot run time: 60223 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1884300920
<details>
<summary>TPC-DS: <b>Total hot run time: 179720 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6c5745887088c3651eff5e3f422a2841d436c90c, data reload: false
query1 937 342 328 328
query2 6711 1953 1859 1859
query3 6700 229 219 219
query4 26086 22380 22171 22171
query5 5929 503 501 501
query6 279 189 188 188
query7 4621 277 278 277
query8 232 215 216 215
query9 9178 2822 2757 2757
query10 586 251 260 251
query11 16083 15298 15468 15298
query12 140 85 79 79
query13 1623 354 343 343
query14 12029 7338 7265 7265
query15 286 192 198 192
query16 6456 282 277 277
query17 1908 498 498 498
query18 1958 280 275 275
query19 291 152 142 142
query20 84 85 81 81
query21 187 96 100 96
query22 4995 4751 4842 4751
query23 32140 31566 31435 31435
query24 12166 2832 2800 2800
query25 580 359 341 341
query26 1729 154 164 154
query27 2817 284 287 284
query28 7014 1896 1898 1896
query29 2040 417 387 387
query30 291 148 147 147
query31 996 783 792 783
query32 96 66 61 61
query33 750 284 288 284
query34 895 452 452 452
query35 901 804 766 766
query36 1426 1198 1244 1198
query37 190 70 72 70
query38 3421 3305 3285 3285
query39 1364 1295 1295 1295
query40 301 102 95 95
query41 38 37 36 36
query42 103 102 96 96
query43 544 521 497 497
query44 1084 712 731 712
query45 210 188 195 188
query46 1070 681 667 667
query47 1631 1605 1587 1587
query48 415 330 321 321
query49 1283 333 334 333
query50 740 373 358 358
query51 5357 5452 5276 5276
query52 107 95 103 95
query53 228 150 163 150
query54 1447 611 589 589
query55 103 91 87 87
query56 226 209 198 198
query57 1010 928 983 928
query58 237 219 221 219
query59 2927 2582 2518 2518
query60 260 250 232 232
query61 96 85 85 85
query62 647 469 450 450
query63 178 152 159 152
query64 5888 1761 1692 1692
query65 3350 3259 3279 3259
query66 1302 332 337 332
query67 15748 15463 15229 15229
query68 9994 550 536 536
query69 584 306 293 293
query70 1784 1618 1539 1539
query71 494 231 223 223
query72 4392 2878 2885 2878
query73 1862 332 328 328
query74 6934 6468 6531 6468
query75 4892 2257 2297 2257
query76 6227 1150 1121 1121
query77 794 271 308 271
query78 9542 8830 8718 8718
query79 1046 521 504 504
query80 566 358 366 358
query81 449 214 212 212
query82 231 86 90 86
query83 165 139 142 139
query84 216 56 57 56
query85 991 301 297 297
query86 383 408 381 381
query87 3552 3420 3393 3393
query88 2862 2333 2339 2333
query89 322 285 260 260
query90 1856 220 205 205
query91 167 141 139 139
query92 61 57 54 54
query93 1022 487 440 440
query94 773 196 194 194
query95 496 438 429 429
query96 631 335 333 333
query97 4287 4142 4208 4142
query98 209 199 186 186
query99 1184 865 904 865
Total cold run time: 291613 ms
Total hot run time: 179720 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1878962384
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
```
Tpch sf100 test result on commit a2c8ace9a3f42b1ed78e33c05ca79f8907acb252, data reload: false
run tpch-sf100 query with default conf and session variables
q1 5498 5180 5199 5180
q2 385 158 159 158
q3 1462 1214 1107 1107
q4 1090 800 784 784
q5 3084 3005 3049 3005
q6 217 132 132 132
q7 980 517 562 517
q8 2163 2287 2220 2220
q9 6681 6635 6673 6635
q10 3174 3095 3084 3084
q11 352 228 219 219
q12 383 239 234 234
q13 4379 3613 3637 3613
q14 256 229 218 218
q15 577 542 521 521
q16 438 400 396 396
q17 1044 551 563 551
q18 7064 6734 6808 6734
q19 1659 1549 1567 1549
q20 595 318 344 318
q21 2857 2402 2488 2402
q22 402 338 333 333
Total cold run time: 44740 ms
Total hot run time: 39910 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 5143 5074 5077 5074
q2 336 229 242 229
q3 3360 3343 3308 3308
q4 2161 2034 2048 2034
q5 5952 5933 5922 5922
q6 221 123 123 123
q7 2388 1911 1946 1911
q8 3529 3659 3658 3658
q9 9070 8998 8926 8926
q10 3865 3886 3900 3886
q11 577 461 493 461
q12 806 630 657 630
q13 3842 3166 3219 3166
q14 301 278 273 273
q15 587 530 520 520
q16 556 505 511 505
q17 2082 1844 1806 1806
q18 8781 8312 8296 8296
q19 1753 1710 1700 1700
q20 2268 1978 1954 1954
q21 5818 5366 5358 5358
q22 566 491 500 491
Total cold run time: 63962 ms
Total hot run time: 60231 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1878923650
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1884166964
<details>
<summary>TPC-H: <b>Total hot run time: 38573 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ad1fea2f74e4a7352101a4457f7ff72bc5b36bf7, data reload: false
------ Round 1 ----------------------------------
q1 17990 5053 5040 5040
q2 2038 143 134 134
q3 10680 1040 1143 1040
q4 10258 777 835 777
q5 7835 3141 3107 3107
q6 203 125 126 125
q7 885 507 488 488
q8 9264 1930 1976 1930
q9 6518 6467 6449 6449
q10 8255 3085 3091 3085
q11 419 216 199 199
q12 357 196 194 194
q13 18132 3428 3428 3428
q14 238 215 210 210
q15 554 516 513 513
q16 432 382 395 382
q17 938 561 490 490
q18 7338 6729 6687 6687
q19 1571 1410 1366 1366
q20 549 308 288 288
q21 2753 2326 2379 2326
q22 368 323 315 315
Total cold run time: 107575 ms
Total hot run time: 38573 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4960 5036 4956 4956
q2 312 200 197 197
q3 3317 3294 3293 3293
q4 2227 2241 2230 2230
q5 5787 5787 5794 5787
q6 191 117 119 117
q7 2302 1822 1839 1822
q8 3425 3550 3535 3535
q9 8834 8827 8836 8827
q10 3749 3810 3810 3810
q11 544 460 442 442
q12 779 599 600 599
q13 6853 3205 3185 3185
q14 287 256 267 256
q15 569 520 510 510
q16 500 486 451 451
q17 2035 2055 2021 2021
q18 8790 8356 8287 8287
q19 1612 1599 1596 1596
q20 2155 1956 1917 1917
q21 6002 5705 5711 5705
q22 561 500 487 487
Total cold run time: 65791 ms
Total hot run time: 60030 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1884174154
<details>
<summary>TPC-DS: <b>Total hot run time: 178578 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ad1fea2f74e4a7352101a4457f7ff72bc5b36bf7, data reload: false
query1 953 339 339 339
query2 6685 1928 1839 1839
query3 6707 210 219 210
query4 25875 22220 22189 22189
query5 5115 499 499 499
query6 279 183 182 182
query7 4619 286 276 276
query8 240 208 209 208
query9 9159 2704 2709 2704
query10 621 231 237 231
query11 16248 15371 15350 15350
query12 135 79 81 79
query13 1624 351 340 340
query14 11950 7363 7256 7256
query15 239 192 209 192
query16 6468 277 275 275
query17 1881 486 486 486
query18 1951 275 269 269
query19 277 144 143 143
query20 88 85 83 83
query21 189 92 96 92
query22 4866 4800 4777 4777
query23 32053 31435 31426 31426
query24 12019 2891 2782 2782
query25 563 340 339 339
query26 1761 160 155 155
query27 2832 274 283 274
query28 7031 1898 1924 1898
query29 1887 396 393 393
query30 288 144 146 144
query31 993 798 795 795
query32 96 65 56 56
query33 745 262 275 262
query34 914 449 447 447
query35 895 752 744 744
query36 1406 1251 1336 1251
query37 103 72 70 70
query38 3400 3314 3255 3255
query39 1334 1310 1279 1279
query40 322 94 91 91
query41 39 35 37 35
query42 102 98 92 92
query43 573 507 505 505
query44 1078 704 724 704
query45 216 189 188 188
query46 1034 659 662 659
query47 1610 1519 1626 1519
query48 397 306 325 306
query49 1268 322 327 322
query50 787 362 321 321
query51 5377 5362 5238 5238
query52 89 93 87 87
query53 224 158 158 158
query54 1449 564 579 564
query55 105 86 83 83
query56 213 200 207 200
query57 1025 1004 971 971
query58 235 217 222 217
query59 2833 2628 2578 2578
query60 255 221 271 221
query61 84 81 82 81
query62 644 463 454 454
query63 176 157 156 156
query64 5881 1708 1652 1652
query65 3347 3265 3281 3265
query66 1300 346 350 346
query67 15614 15652 14925 14925
query68 12853 549 538 538
query69 583 275 281 275
query70 1664 1599 1589 1589
query71 513 220 224 220
query72 4990 2807 2864 2807
query73 2970 333 321 321
query74 7107 6468 6462 6462
query75 5327 2258 2304 2258
query76 6362 890 1115 890
query77 699 256 291 256
query78 10000 8568 8498 8498
query79 1049 517 495 495
query80 564 356 352 352
query81 449 217 210 210
query82 212 98 88 88
query83 162 144 137 137
query84 284 60 57 57
query85 1089 284 277 277
query86 405 383 387 383
query87 3628 3450 3390 3390
query88 3003 2318 2313 2313
query89 324 255 249 249
query90 1875 209 205 205
query91 165 132 132 132
query92 59 61 53 53
query93 1271 435 481 435
query94 836 196 187 187
query95 467 437 435 435
query96 629 333 333 333
query97 4281 4193 4180 4180
query98 206 200 188 188
query99 1104 838 887 838
Total cold run time: 295896 ms
Total hot run time: 178578 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](fe) add check for leg/lead function params [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #29617:
URL: https://github.com/apache/doris/pull/29617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1888808024
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1888808160
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1878876652
<details>
<summary>TPC-H: <b>Total hot run time: 38200 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2147b7b17f5a70dc9f5ed51ad5e2baf367b9ce16, data reload: false
------ Round 1 ----------------------------------
q1 17674 4930 4914 4914
q2 2012 154 142 142
q3 10582 1136 1173 1136
q4 10194 737 812 737
q5 7775 2931 2824 2824
q6 200 125 124 124
q7 909 505 513 505
q8 9283 1945 1960 1945
q9 6381 6378 6364 6364
q10 8209 3016 2978 2978
q11 421 219 229 219
q12 384 229 229 229
q13 17999 3395 3395 3395
q14 242 214 199 199
q15 550 516 499 499
q16 450 374 417 374
q17 941 717 573 573
q18 7208 6678 6586 6586
q19 1551 1513 1502 1502
q20 702 327 311 311
q21 2761 2432 2339 2339
q22 367 305 310 305
Total cold run time: 106795 ms
Total hot run time: 38200 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4946 4935 4869 4869
q2 332 235 234 234
q3 3258 3275 3273 3273
q4 2102 2025 2004 2004
q5 5738 5744 5744 5744
q6 196 114 115 114
q7 2283 1905 1882 1882
q8 3342 3403 3424 3403
q9 8703 8713 8668 8668
q10 3790 3833 3831 3831
q11 540 438 446 438
q12 794 616 624 616
q13 6906 3189 3185 3185
q14 291 269 256 256
q15 540 499 499 499
q16 567 509 504 504
q17 1856 1840 1839 1839
q18 8571 8289 8172 8172
q19 1589 1611 1618 1611
q20 2145 1946 1928 1928
q21 5538 5228 5336 5228
q22 505 450 466 450
Total cold run time: 64532 ms
Total hot run time: 58748 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](fe) add check for leg/lead function params [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #29617:
URL: https://github.com/apache/doris/pull/29617#issuecomment-1880305766
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org