You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@eventmesh.apache.org by mi...@apache.org on 2022/10/27 08:19:38 UTC

[incubator-eventmesh] branch master updated: Use logger to print exception messages

This is an automated email from the ASF dual-hosted git repository.

mikexue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-eventmesh.git


The following commit(s) were added to refs/heads/master by this push:
     new e56404e2 Use logger to print exception messages
     new e96c94d0 Merge pull request #1954 from xiaohu12138/fix_patch_xiaohu
e56404e2 is described below

commit e56404e2e73a484b147ea29ca512f6e4a6402f27
Author: xiaohu12138 <92...@qq.com>
AuthorDate: Thu Oct 27 11:29:24 2022 +0800

    Use logger to print exception messages
---
 .../eventmesh/connector/knative/consumer/PullConsumerImpl.java | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/eventmesh-connector-plugin/eventmesh-connector-knative/src/main/java/org/apache/eventmesh/connector/knative/consumer/PullConsumerImpl.java b/eventmesh-connector-plugin/eventmesh-connector-knative/src/main/java/org/apache/eventmesh/connector/knative/consumer/PullConsumerImpl.java
index b827503d..1bc78f68 100644
--- a/eventmesh-connector-plugin/eventmesh-connector-knative/src/main/java/org/apache/eventmesh/connector/knative/consumer/PullConsumerImpl.java
+++ b/eventmesh-connector-plugin/eventmesh-connector-knative/src/main/java/org/apache/eventmesh/connector/knative/consumer/PullConsumerImpl.java
@@ -39,6 +39,8 @@ import java.util.concurrent.atomic.AtomicLong;
 import io.cloudevents.CloudEvent;
 
 import com.google.common.collect.Lists;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class PullConsumerImpl {
 
@@ -54,6 +56,8 @@ public class PullConsumerImpl {
     public ConcurrentMap<String /* topic */, String /* responseBody */> subscriptionInner;
     public EventListener eventListener;
 
+    private static final Logger logger = LoggerFactory.getLogger(PullConsumerImpl.class);
+
     public PullConsumerImpl(final Properties properties) throws Exception {
         this.properties = properties;
         this.topicList = Lists.newArrayList();
@@ -76,12 +80,12 @@ public class PullConsumerImpl {
                     try {
                         subscriptionInner.put(item.getTopic(), defaultConsumer.pullMessage(item.getTopic(), properties.getProperty("serviceAddr")));
                     } catch (Exception e) {
-                        e.printStackTrace();
+                        logger.error(e.getMessage());
                     }
                 }
             );
         } catch (Exception e) {
-            e.printStackTrace();
+            logger.error(e.getMessage());
         }
     }
 
@@ -90,7 +94,7 @@ public class PullConsumerImpl {
             // Unsubscribe topic:
             topicList.remove(topic);
         } catch (Exception e) {
-            e.printStackTrace();
+            logger.error(e.getMessage());
         }
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: commits-help@eventmesh.apache.org