[GitHub] [arrow] mapleFU commented on a diff in pull request #35731: GH-35729: [C++][Parquet] Implement batch interface for BloomFilter in Parquet

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #35731:
URL: https://github.com/apache/arrow/pull/35731#discussion_r1203475907


##########
cpp/src/parquet/bloom_filter.h:
##########
@@ -200,6 +257,11 @@ class PARQUET_EXPORT BlockSplitBloomFilter : public BloomFilter {
 
   bool FindHash(uint64_t hash) const override;
   void InsertHash(uint64_t hash) override;
+  void InsertHashes(const uint64_t* hashes, int num_values) override {
+    for (int i = 0; i < num_values; ++i) {
+      InsertHash(hashes[i]);

Review Comment:
   Emmm I guess I should mark `BlockSplitBloomFilter` as final to avoid virtual call



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org