You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jena.apache.org by an...@apache.org on 2017/07/28 13:48:50 UTC
[2/3] jena git commit: JENA-1378: Set the accept header in the
default use case.
JENA-1378: Set the accept header in the default use case.
Project: http://git-wip-us.apache.org/repos/asf/jena/repo
Commit: http://git-wip-us.apache.org/repos/asf/jena/commit/b11e8739
Tree: http://git-wip-us.apache.org/repos/asf/jena/tree/b11e8739
Diff: http://git-wip-us.apache.org/repos/asf/jena/diff/b11e8739
Branch: refs/heads/master
Commit: b11e87393e520815c669bd0086434c2960496b78
Parents: a89605c
Author: Andy Seaborne <an...@apache.org>
Authored: Thu Jul 27 10:12:40 2017 +0100
Committer: Andy Seaborne <an...@apache.org>
Committed: Thu Jul 27 10:12:40 2017 +0100
----------------------------------------------------------------------
.../main/java/org/apache/jena/riot/RDFParser.java | 18 ++++++++++++------
.../org/apache/jena/riot/RDFParserBuilder.java | 8 +++++---
2 files changed, 17 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jena/blob/b11e8739/jena-arq/src/main/java/org/apache/jena/riot/RDFParser.java
----------------------------------------------------------------------
diff --git a/jena-arq/src/main/java/org/apache/jena/riot/RDFParser.java b/jena-arq/src/main/java/org/apache/jena/riot/RDFParser.java
index 977789b..da8ef55 100644
--- a/jena-arq/src/main/java/org/apache/jena/riot/RDFParser.java
+++ b/jena-arq/src/main/java/org/apache/jena/riot/RDFParser.java
@@ -320,13 +320,19 @@ public class RDFParser {
}
TypedInputStream in;
+ urlStr = StreamManager.get(context).mapURI(urlStr);
if ( urlStr.startsWith("http://") || urlStr.startsWith("https://") ) {
- // For complete compatibility, we have to let null pass through.
- // Pair with RDFParserBuilder.buildHttpClient
- // Objects.requireNonNull(httpClient);
- // Remap.
- urlStr = StreamManager.get(context).mapURI(urlStr);
- in = HttpOp.execHttpGet(urlStr, null, httpClient, null);
+ // Need more control than LocatorURL provides. We could use it for the
+ // httpClient == null case.
+ //
+ // HttpOp.execHttpGet(,acceptHeader,) overrides the HttpClient default setting.
+ //
+ // If there is an explicitly set HttpClient use that as given, and do not override
+ // the accept header (i.e. pass null to arg accpetHeader in execHttpGet).
+ // Else, use httpOp as setup and set the accept header.
+ String acceptHeader =
+ ( httpClient == null ) ? WebContent.defaultRDFAcceptHeader : null;
+ in = HttpOp.execHttpGet(urlStr, acceptHeader, httpClient, null);
} else {
in = streamManager.open(urlStr);
}
http://git-wip-us.apache.org/repos/asf/jena/blob/b11e8739/jena-arq/src/main/java/org/apache/jena/riot/RDFParserBuilder.java
----------------------------------------------------------------------
diff --git a/jena-arq/src/main/java/org/apache/jena/riot/RDFParserBuilder.java b/jena-arq/src/main/java/org/apache/jena/riot/RDFParserBuilder.java
index ed1ca7b..aaacd08 100644
--- a/jena-arq/src/main/java/org/apache/jena/riot/RDFParserBuilder.java
+++ b/jena-arq/src/main/java/org/apache/jena/riot/RDFParserBuilder.java
@@ -26,7 +26,6 @@ import java.util.*;
import org.apache.http.Header;
import org.apache.http.client.HttpClient;
-import org.apache.http.impl.client.cache.CachingHttpClientBuilder;
import org.apache.http.message.BasicHeader;
import org.apache.jena.atlas.lib.IRILib;
import org.apache.jena.graph.BlankNodeId;
@@ -35,6 +34,7 @@ import org.apache.jena.riot.lang.LabelToNode;
import org.apache.jena.riot.system.*;
import org.apache.jena.riot.system.stream.StreamManager;
import org.apache.jena.riot.web.HttpNames;
+import org.apache.jena.riot.web.HttpOp ;
import org.apache.jena.sparql.core.DatasetGraph;
import org.apache.jena.sparql.util.Context;
@@ -504,8 +504,10 @@ public class RDFParserBuilder {
Header header = new BasicHeader(k, v);
hdrs.add(header);
});
- HttpClient hc = CachingHttpClientBuilder.create().setDefaultHeaders(hdrs).build();
- return hc;
+ HttpClient hc = HttpOp.createPoolingHttpClientBuilder()
+ .setDefaultHeaders(hdrs)
+ .build() ;
+ return hc ;
}
/**