You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@helix.apache.org by GitBox <gi...@apache.org> on 2019/07/24 18:31:53 UTC

[GitHub] [helix] dasahcc commented on a change in pull request #360: Romve TODO NPE log for computeResourceBestPossibleState

dasahcc commented on a change in pull request #360: Romve TODO NPE log for computeResourceBestPossibleState
URL: https://github.com/apache/helix/pull/360#discussion_r306959456
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
 ##########
 @@ -263,19 +263,6 @@ private boolean computeResourceBestPossibleState(ClusterEvent event, ResourceCon
       } catch (Exception e) {
         LogUtil.logError(logger, _eventId,
             "Error computing assignment for resource " + resourceName + ". Skipping.");
-        // TODO : remove this part after debugging NPE
 
 Review comment:
   Have you add NPE checks for partition assignment?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services